copr / copr

Clone

#948 copr-cli: fixes traceback when lost connection during copr-cli build
Merged 4 years ago by msuchy. Opened 4 years ago by thrnciar.
copr/ thrnciar/copr copr-cli-lost-connection-traceback  into  master

file modified
+5 -2 
@@ -9,6 +9,7 @@ 
 

  import time
 

  import six
 

  import simplejson
 

+ import requests
 

  from collections import defaultdict
 

  

  import logging
 
@@ -136,8 +137,10 @@ 
 

                  for build_id in watched:
 

                      if build_id in done:
 

                          continue
 

- 

-                     build_details = self.client.build_proxy.get(build_id=build_id)
 

+                     try:
 

+                         build_details = self.client.build_proxy.get(build_id=build_id)
 

+                     except requests.ConnectionError as e:
 

+                         raise CoprRequestException(e)
 

                      now = datetime.datetime.now()
 

                      if prevstatus[build_id] != build_details.state:
 

                          prevstatus[build_id] = build_details.state

It can be any error, not only "Connection interrupt". This should raise similar error message as the one coming from requests.

rebased onto 0d7573c
4 years ago

+1

Pull-Request has been merged by msuchy
4 years ago
Changes Summary 1
+5 -2
file changed
cli/copr_cli/main.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.