#9 Allow disabling FAS login (by configuration, not by patching)
Closed 7 years ago by praiskup. Opened 7 years ago by praiskup.
Unknown source FAS_related_options  into  master

No commits found

no initial comment

4 new commits added

  • [frontend] allow disabling FAS (when krb5 auth is used)
  • [frontend] allow hiding 'dnf copr enable' instructions
  • [frontend] move footer project info into separate template
  • [frontend] overwrite also button:focus and thead style
7 years ago

There is actually lots of stuff included in this PR:

1) LAYOUT_OVERVIEW_HIDE_QUICK_ENABLE to hide quick enable window
2) "modularizing" user info and project info
3) Allow disabling FAS login (being the title)

So could you please trim it down somehow or separate it into different pull requests to make it easier to comment on the changes?

Also, while copr-frontend-design was a good name when overriding just static files, it is no longer a fitting name when you enable overriding whole templates (like user_info.html and project_info.html). Then it should be called something like "copr-frontend-flavor".

So could you please trim it down somehow or separate it into different pull requests to make it easier to comment on the changes?

Sure.

Also, while copr-frontend-design was a good name when overriding just static files, it is no longer a fitting name when you enable overriding whole templates (like user_info.html and project_info.html). Then it should be called something like "copr-frontend-flavor".

It is still a good time for renaming, makes sense.

I tried to reorganize into two separate pull request, HTH. "flavor" instead of "design" term is used now:
https://pagure.io/copr/copr/pull-request/13
https://pagure.io/copr/copr/pull-request/12

Pull-Request has been closed by praiskup

7 years ago
Metadata