#850 [frontend] fix "add project" form for groups
Merged 4 years ago by msuchy. Opened 4 years ago by praiskup.
Unknown source fix-group-add-form  into  master

@@ -153,10 +153,6 @@

  @coprs_ns.route("/g/<group_name>/new/", methods=["POST"])

  @login_required

  def copr_new(username=None, group_name=None):

-     return process_copr_new(group_name)

- 

- 

- def process_copr_new(group_name=None):

      """

      Receive information from the user (and group) on how to create its new copr

      and create it accordingly.
@@ -189,16 +185,14 @@

                  follow_fedora_branching=form.follow_fedora_branching.data,

                  delete_after_days=form.delete_after_days.data,

              )

+ 

+             db.session.commit()

+             after_the_project_creation(copr, form)

+             return flask.redirect(url_for_copr_details(copr))

          except (exceptions.DuplicateException, exceptions.NonAdminCannotCreatePersistentProject) as e:

              flask.flash(str(e), "error")

-             return flask.render_template(redirect, form=form)

  

-         db.session.commit()

-         after_the_project_creation(copr, form)

- 

-         return flask.redirect(url_for_copr_details(copr))

-     else:

-         return flask.render_template(redirect, form=form, group=group)

+     return flask.render_template(redirect, form=form, group=group)

  

  

  def after_the_project_creation(copr, form):

Simplify the code path so we have one call to
flask.render_template() with all the needed arguments (we missed
'group' argument before).

Fixes #847.

rebased onto 3a603fc58ddaeb297d635787a4a65af74144b067

4 years ago

rebased onto d673f630aad34887c2b08bf471f0dbcb1d48b7a0

4 years ago

rebased onto 1806b6d

4 years ago

Pull-Request has been merged by msuchy

4 years ago