#743 [rpmbuild] require even nosync.i686
Merged 4 years ago by praiskup. Opened 4 years ago by praiskup.
Unknown source require-nosync-i686  into  master

file modified
+8 -2
@@ -10,6 +10,9 @@

  %global rpm_python      rpm-python

  %endif

  

+ # do not build debuginfo sub-packages

+ %define debug_package %nil

+ 

  %define latest_requires() \

  Requires: %1 \

  %{expand: %%global latest_requires_packages %1 %%{?latest_requires_packages}}
@@ -20,7 +23,6 @@

  Release: 1%{?dist}

  URL: https://pagure.io/copr/copr

  License: GPLv2+

- BuildArch: noarch

  

  # Source is created by:

  # git clone https://pagure.io/copr/copr.git
@@ -94,8 +96,12 @@

  Requires: libselinux-python

  Requires: libsemanage-python

  %endif

- # for mock to allow 'nosync = True'

+ # for mock to allow: config_opts['nosync'] = True

  Requires: nosync

+ %ifarch x86_64

+ # multilib counterpart to avoid: config_opts['nosync_force'] = True

+ Requires: nosync.i686

+ %endif

  Requires: openssh-clients

  Requires: pyp2rpm

  # We need %%pypi_source defined, which is in 3-29+

Even though it is mostly cosmetic change, this requires us to
switch from Buildarch: noarch.

rebased onto 5d751d793b29255ce3169829972173d7ec275015

4 years ago

But, this variable is not used anywhere ...

That's standard way how to not build debuginfo subpackages when you have non-noarch package.

rebased onto a43236923d9beeb5f6cc4225b85656ce70e67569

4 years ago

I changed the commit message, it looked like the change is rather "cosmetic" (while I wanted to say that the fact that we switched from noarch to non-noarch is rather cosmetic change).

rebased onto c5bb33f

4 years ago

I also documented why %debug_package is defined.

Alright. It looks good, thank you.

+1

Pull-Request has been merged by praiskup

4 years ago