#725 [rpmbuild] don't define %_disable_source_fetch
Merged 6 months ago by praiskup. Opened 6 months ago by praiskup.
copr/ praiskup/copr dont-download-sources  into  master

@@ -72,7 +72,6 @@ 

              "--sources", sources,

              "--configdir", configdir,

              "--resultdir", resultdir,

-             "--define", "%_disable_source_fetch 0",

              "--uniqueext", get_mock_uniqueext(),

              "-r", "child"]

  

We could think about defining %_disable_source_fetch 0 when we
build SRPm that is being imported to dist-git; but never later -
when we already build from dist-git.

Reported in
https://lists.fedorahosted.org/archives/list/copr-devel@lists.fedorahosted.org/thread/A2VFHRZBC2Y6NE2AOTTR5QMYXDZ33OVU/

rebased onto 6534905b62702b459ac3e17ecd10ece746fe5e1c

6 months ago

rebased onto 9c7be360c67d402d537f391cfdf7605a775214c2

6 months ago

IMHO this will break things. See https://docs.pagure.org/copr.copr/user_documentation.html#urls

You can also just input a URL to an rpm .spec file (package metadata) that describe the package without including the actual build sources. The build sources, being again available on a public server under https, will be then downloaded by COPR automatically during the SRPM build process.

Is it related to the PR, or this feature is ensured by some other code?

I believe the code I touched is only related to RPM building, at the phase when we already have everything imported into dist-git.

IOW, if this breaks the "source preparation" (or SRPM preparation) phase (related to spec file download, + source download) - there's some design issue I don't see ATM.

I believe the code I touched is only related to RPM building, at the phase when we already have everything imported into dist-git.

I've looked in the code and you seem to be right. Therefore +1 from me.
If something breaks, beaker tests will hopefully discover it.

rebased onto f394064

6 months ago

Pull-Request has been merged by praiskup

6 months ago

Could you please let me know once this is deployed?

I can not map to V2 milestone this PR :-(, but it will be released with the regular copr release batch (announced on copr-devel list). I'll try to recall to ping you.

(announced on copr-devel list)

That works for me. No need to ping me extra. Thanks.