#72 [builder] package 'rpkg' script as /bin/copr-rpkg
Closed 6 years ago by clime. Opened 6 years ago by praiskup.
Unknown source builder-package-rpkg  into  master

No commits found

Related: rhbz#1452202

Well, is this acceptable for the time being (till we have rpkg back in fedora)?

rebased

6 years ago

Yes, it's ok. Note that I am more inclined to continue developing upon the builder-perl with the task-id as input, which is something we surely want.

Yes, it's ok. Note that I am more inclined to continue developing upon the builder-perl

Thanks for the review. I don't think that re-implementing is needed (shell is better for trivial wrappers)), but at least you've chosen perl for re-implementing language ... So feel free to close/merge this (depending on whether copr-builder is dead or not).

with the task-id as input, which is something we surely want.

Surely? I'm not fan of this, as long as the 'build_id' means that each builder will all the time both (a) generate some srpm from remote storage and (b) build RPMs from that SRPM. That's racy and unfriendly to remote source code providers (Issue #68 and PR #70).

Yes, it's ok. Note that I am more inclined to continue developing upon the builder-perl

Thanks for the review. I don't think that re-implementing is needed (shell is better for trivial wrappers)), but at least you've chosen perl for re-implementing language ... So feel free to close/merge this (depending on whether copr-builder is dead or not).

with the task-id as input, which is something we surely want.

Surely? I'm not fan of this, as long as the 'build_id' means that each builder will all the time both (a) generate some srpm from remote storage and (b) build RPMs from that SRPM. That's racy and unfriendly to remote source code providers (Issue #68 and PR #70).

It's task_id, not build_id.

I think the problems you mention (while I doubt that they are really problems) can be quite easily fixed.

I will close this then.

Pull-Request has been closed by clime

6 years ago

I think the problems you mention (while I doubt that they are really problems) can be quite easily fixed.

Those are real problems, and once you do everything on builder in one step, you make it unfixable unless we revert back... this requires personal chat so I can describe the issues properly.

I am ok with discussing it. Although I have already described the solutions but I guess you just ignore them.

Metadata