PR#701: [frontend] traceback when forked_from project deleted - copr/copr

copr / copr

#701 [frontend] traceback when forked_from project deleted

Closed 4 years ago by praiskup. Opened 5 years ago by praiskup.

Unknown source forked-from-deleted-1 into master

[frontend] traceback when forked_from project deleted

Pavel Raiskup • 5 years ago

ebeccc2

file modified

		`@@ -1295,6 +1295,8 @@`
		`def dist_git_url(self):`
		`if app.config["DIST_GIT_URL"]:`
		`if self.state == "forked":`
		`+ if self.build.copr.forked_from.deleted:`
		`+ return None`
		`copr_dirname = self.build.copr.forked_from.main_dir.full_name`
		`else:`
		`copr_dirname = self.build.copr_dir.full_name`

praiskup commented 5 years ago

Fixes: #700, PR#701

frostyx commented 4 years ago

So, the problem is, that we are trying to print dist-git URL to the original project which can be deleted. This PR keeps clickable "Dist Git Source" hash for forks, with the original project that still exists, but prints plain-text source hash (without a link) for forks without their original project.

Looks good to me, +1

praiskup commented 4 years ago

f318bdaa0f819ca7fdd1271bdb60660a6ae830eb

Pull-Request has been closed by praiskup

4 years ago