PR#673: [doc] amend pypi release process - copr/copr

copr / copr

#673 [doc] amend pypi release process

Closed 4 years ago by praiskup. Opened 5 years ago by msuchy.

copr/ msuchy/copr pypi into master

[doc] amend pypi release process

Miroslav Suchý • 4 years ago

3b2742c

doc/how_to_release_copr.rst

file modified

+7 -3

		`@@ -67,17 +67,21 @@`
		Run :ref:`beaker_tests` and check the results.


		`- Release python-copr to PyPi`
		`- ---------------------------`
		`+ Release packages to PyPI`
		`+ ------------------------`

		Make sure you have `~/.pypirc` correctly set up and run::

		`- version=<current_pkg_version> /usr/bin/python setup.py sdist --format=gztar upload`
		`+ dnf install twine`
		`+ version=<current_pkg_version> python3 setup.py sdist`
		`+ twine upload dist/<NAME-VERSION>.tar.gz`

		Substitute `<current_pkg_version>` with the current package version.

		`If you cannot run that, tell somebody with access to run that (msuchy has access).`

		+ This needs to be run for `copr-common`, `python` and `copr-cli`.
		`+`
		`.. _build_packages_for_production:`

		`Build packages for production`

no initial comment

praiskup commented on line 13 of doc/how_to_release_copr.rst 5 years ago

Do we really need copr-common?

frostyx commented on line 13 of doc/how_to_release_copr.rst 5 years ago

Do we really need copr-common?

IMHO no, because copr-common is supposed to be an internal thing, that is not supposed to be installed by users.

This needs to be run for copr-common, python and copr-cli.

Please, update the chapter title from "Release python-copr to PyPi" to rather more accurate "Release pacakges to PyPI".

frostyx commented on line 7 of doc/how_to_release_copr.rst 5 years ago

IMHO there should be added BuildRequires for a package providing twine command, or at least documented in this chapter, how can I get it.

frostyx commented 5 years ago

I've added some notes, but otherwise, it looks good to me.

praiskup commented on line 13 of doc/how_to_release_copr.rst 5 years ago

IMHO no, because copr-common is supposed to be an internal thing, that is not supposed to be installed by users.

I've interpreted this differently: It is internal thing, so only copr components should depend on (and use) it. Not that by design copr-cli can not use it. So it doesn't really mean that it couldn't live on PyPI, IMO we only don't need it yet.