PR#654: [backend] don't rely on createrepo from prunerepo - copr/copr

copr / copr

#654 [backend] don't rely on createrepo from prunerepo

Merged 5 years ago by praiskup. Opened 5 years ago by frostyx.

copr/ frostyx/copr prunerepo-appstream into master

[backend] don't rely on createrepo from prunerepo

Jakub Kadlčík • 5 years ago

77366eb

backend/run/copr_prune_results.py

file modified

+6 -1

		`@@ -21,6 +21,7 @@`
		`from backend.helpers import BackendConfigReader`
		`from backend.helpers import get_auto_createrepo_status,get_persistent_status,get_auto_prune_status`
		`from backend.frontend import FrontendClient`
		`+ from backend.createrepo import createrepo`

		`DEF_DAYS = 14`

		`@@ -161,9 +162,13 @@`
		`continue`

		`try:`
		`- cmd = ['prunerepo', '--verbose', '--days={0}'.format(self.prune_days), '--cleancopr', chroot_path]`
		`+ cmd = ['prunerepo', '--verbose', '--days', str(self.prune_days),`
		`+ '--cleancopr', '--nocreaterepo', chroot_path]`
		`stdout = runcmd(cmd)`
		`loginfo(stdout)`
		`+ createrepo(path=chroot_path, front_url=self.opts.frontend_base_url,`
		`+ username=username, projectname=projectname,`
		`+ override_acr_flag=True)`
		`except Exception as err:`
		`logexception(err)`
		`logerror("Error pruning chroot {}/{}:{}".format(username, projectdir, sub_dir_name))`

frostyx commented 5 years ago

Fix #646

Prunerepo is able to run createrepo_c command after pruning
but it has limited possibilities. For example, it cannot create
appstream data, see #646. Instead of trying keep copr features
in sync with createrepo_c possibilities in prunerepo, rather
run prunerepo with --nocreaterepo and run our createrepo
function afterwards.