PR#608: [frontend] fix module builds table - copr/copr

Jakub Kadlčík • 5 years ago

73adebd

file modified

		`@@ -26,8 +26,12 @@`
		`</a></b>`
		`</td>`
		`<td>`
		`+ {# When builds are queried with custom SQL select #}`
		`{% if build.pkg_name %}`
		`{{ build.pkg_name }}`
		+ {# When builds are really a ``models.Build`` instances #}
		`+ {% elif build.package_name %}`
		`+ {{ build.package_name }}`
		`{% else %}`
		`-`
		`{% endif %}`

file modified

+2 -2

		`@@ -2,7 +2,7 @@`
		`{% from "coprs/detail/_builds_forms.html" import copr_build_cancel_form, copr_build_repeat_form, copr_build_delete_form %}`
		`{% from "coprs/detail/_describe_source.html" import describe_source %}`
		`{% from "coprs/detail/_describe_failure.html" import describe_failure %}`
		`- {% from "coprs/detail/_package_table.html" import package_table with context %}`
		`+ {% from "coprs/detail/_builds_table.html" import builds_table with context %}`
		`{% from "_helpers.html" import chroot_to_os_logo, build_state_text, build_state, copr_name %}`
		`{% block title %}Module {{ module.id }} in {{ copr_name(copr) }}{% endblock %}`

		`@@ -174,7 +174,7 @@`
		`</div>`
		`</div>`

		`- {{package_table(module.builds)}}`
		`+ {{builds_table(module.builds)}}`
		`</div>`

		`</div>`

We want to show builds table, not package-builds table, because
otherwise there is package name missing.

I can not test this locally :-( but otherwise it sounds logically; +1

Edited 5 years ago by praiskup

I can not test this locally :-(

Module builds should work on local instances by default, let me know if you have any issues with it and want to get them fixed.

but otherwise it sounds logically

You can compare these screenshots. This is how the module page looks now
https://frostyx.fedorapeople.org/pagure/without-package-name.png
There is no package name in the table, so you don't know what packages have failed.

rebased onto 73adebd

5 years ago