#58 Allow docker test image to run sanity tests
Merged 6 years ago by clime. Opened 6 years ago by frostyx.
copr/ frostyx/copr docker_image_sanity  into  master

@@ -1,4 +1,4 @@ 

- FROM fedora:23

+ FROM fedora:25

  MAINTAINER clime@redhat.com

  

  ENV container docker
@@ -29,6 +29,11 @@ 

  RUN dnf -y install python-jedi

  RUN dnf -y install procps-ng

  

+ # Sanity tests

+ RUN wget https://beaker-project.org/yum/beaker-client-Fedora.repo -P /etc/yum.repos.d

+ RUN dnf -y install rhts-test-env beakerlib

+ 

+ 

  RUN echo "LANG=en_US.UTF-8" >> /etc/locale

  RUN setcap cap_net_raw,cap_net_admin+p /usr/bin/ping

  

I tried to run sanity tests in docker test environment and I've encountered few minor issues. So I suggest this patch, what do you think @clime?

We have beaker-tests/Install for this. copr-cli is not required for a backend or dist-git test.

Again, there is beaker-tests/Install .config/copr setup.

Installing rhts-test-env and beakerlib (+adding relevant repo for it) and bumping fedora version is cool.

Thank you @clime, for the review.
I am going to address the comments

2 new commits added

  • [beaker-tests] copr-cli is not supposed to be installed in Dockerfile
  • [beaker-tests] upgrade to fedora 25
6 years ago

Several things I want to talk about.

I didn't realize, that there is a beaker-tests/Install/Config-copr-cli/config. I removed the sharing as you suggested.

My need to install copr-cli manually and then adding it to Dockerfile probably came from the situation that I tried my copr-cli commands in shell, before adding them to tests. So install phase probably wasn't run yet. What about running the beaker-tests/Install stuff in the Dockerfile? In that scenario when you run the docker container, it would be 100% prepared.

That Dockerfile is also supposed to serve as platform for dist-git and backend tests (in beaker-tests/Regression/). I think it is better just document that the Install script should be run before the Sanity test.

That Dockerfile is also supposed to serve as platform for dist-git and backend tests (in beaker-tests/Regression/).

Ok, lets not complicate things and not install it in the Dockerfile

I think it is better just document that the Install script should be run before the Sanity test.

As I am reading through beaker-tests/README it basically says so.

From my point of view, the PR is finished.

Pull-Request has been merged by clime

6 years ago
Metadata