#550 [frontend][backend] require libmodulemd in at least 1.7.0
Merged 5 years ago by msuchy. Opened 5 years ago by frostyx.
copr/ frostyx/copr requires-libmodulemd-version  into  master

file modified
+2 -1
@@ -48,7 +48,8 @@ 

  Requires:   euca2ools

  Requires:   gawk

  Requires:   libappstream-glib-builder

- Requires:   libmodulemd

+ Requires:   libmodulemd < 2

+ Requires:   libmodulemd >= 1.7.0

I'm curious whether we still need the libmodulemd < 2 require.

Unfortunately, we do. The version 2.x changed the API and we haven't rewritten our code yet, to work with it. And I am personally not planning to do in any near future because it is just a rewrite with no added value for us. So as long as version 1.7.0 is supported ...

  Requires:   lighttpd

  Requires:   logrotate

  Requires:   mock

@@ -97,6 +97,7 @@ 

  BuildRequires: python3-flask-whooshee

  BuildRequires: python3-gobject

  BuildRequires: libmodulemd < 2

+ BuildRequires: libmodulemd >= 1.7.0

  BuildRequires: python3-requests

  BuildRequires: redis

  %endif
@@ -130,6 +131,7 @@ 

  Requires: python3-openid-teams

  Requires: python3-gobject

  Requires: libmodulemd < 2

+ Requires: libmodulemd >= 1.7.0

  Requires: python3-pygments

  Requires: python3-CommonMark

  Requires: python3-psycopg2

That is the version in which Modulemd.ModuleStream class was added.
I needed to manually install the correct version several times on
multiple instances, so we should ideally specify it in spec files.

I'm curious whether we still need the libmodulemd < 2 require.

Unfortunately, we do. The version 2.x changed the API and we haven't rewritten our code yet, to work with it. And I am personally not planning to do in any near future because it is just a rewrite with no added value for us. So as long as version 1.7.0 is supported ...

rebased onto 18a726b

5 years ago

Pull-Request has been merged by msuchy

5 years ago