PR#526: add requires python3-novaclient - copr/copr

copr / copr

#526 add requires python3-novaclient

Merged 5 years ago by msuchy. Opened 5 years ago by msuchy.

copr/ msuchy/copr requires into master

add requires python3-novaclient

Miroslav Suchý • 5 years ago

75405aa

sort requires

Miroslav Suchý • 5 years ago

3b4505b

backend/copr-backend.spec

file modified

+34 -33

		`@@ -19,60 +19,61 @@`
		`BuildArch: noarch`
		`BuildRequires: asciidoc`
		`BuildRequires: libxslt`
		`- BuildRequires: util-linux`
		`- BuildRequires: systemd`
		`BuildRequires: redis`
		`+ BuildRequires: systemd`
		`+ BuildRequires: util-linux`

		`BuildRequires: python3-devel`
		`BuildRequires: python3-setuptools`
		`BuildRequires: python3-requests`

		`- BuildRequires: python3-pytest`
		`- BuildRequires: python3-pytest-cov`
		`- BuildRequires: python3-munch`
		`- BuildRequires: python3-oslo-concurrency`
		`- BuildRequires: python3-daemon`
		`- BuildRequires: python3-requests`
		`- BuildRequires: python3-setproctitle`
		`- BuildRequires: python3-retask`
		`BuildRequires: python3-configparser`
		`BuildRequires: python3-copr`
		`+ BuildRequires: python3-daemon`
		`BuildRequires: python3-dateutil`
		`+ BuildRequires: python3-fedmsg`
		`+ BuildRequires: python3-munch`
		`+ BuildRequires: python3-oslo-concurrency`
		`+ BuildRequires: python3-pytest`
		`+ BuildRequires: python3-pytest-cov`
		`BuildRequires: python3-pytz`
		`+ BuildRequires: python3-requests`
		`+ BuildRequires: python3-retask`
		`+ BuildRequires: python3-setproctitle`
		`BuildRequires: python3-sphinx`
		`- BuildRequires: python3-fedmsg`

		`+ Requires: (copr-selinux if selinux-policy-targeted)`
		`Requires: ansible`
		`- Requires: obs-signd`
		`- Requires: lighttpd`
		`+ Requires: createrepo_c`
		`+ Requires: crontabs`
		`Requires: euca2ools`
		`- Requires: rsync`
		`- Requires: openssh-clients`
		`+ Requires: gawk`
		`+ Requires: libappstream-glib-builder`
		`+ Requires: libmodulemd`
		`+ Requires: lighttpd`
		`+ Requires: logrotate`
		`Requires: mock`
		`- Requires: createrepo_c`
		`- Requires: python3-munch`
		`+ Requires: obs-signd`
		`+ Requires: openssh-clients`
		`+ Requires: prunerepo`
		`+ Requires: python3-configparser`
		`+ Requires: python3-copr`
		`+ Requires: python3-copr-common > 0.4`
		`Requires: python3-daemon`
		`+ Requires: python3-dateutil`
		`+ Requires: python3-fedmsg`
		`+ Requires: python3-gobject`
		`+ Requires: python3-munch`
		`+ Requires: python3-netaddr`
		`+ Requires: python3-novaclient`
		`Requires: python3-oslo-concurrency`
		`+ Requires: python3-pytz`
		`Requires: python3-requests`
		`- Requires: python3-setproctitle`
		`Requires: python3-retask`
		`- Requires: python3-copr`
		`- Requires: python3-dateutil`
		`- Requires: python3-pytz`
		`- Requires: python3-netaddr`
		`- Requires: python3-copr-common > 0.4`
		`- Requires: python3-gobject`
		`- Requires: libmodulemd`
		`- Requires: python3-configparser`
		`- Requires: python3-fedmsg`
		`+ Requires: python3-setproctitle`
		`Requires: redis`
		`- Requires: logrotate`
		`- Requires: gawk`
		`- Requires: crontabs`
		`- Requires: prunerepo`
		`- Requires: libappstream-glib-builder`
		`Requires: rpm-sign`
		`- Requires: (copr-selinux if selinux-policy-targeted)`
		`+ Requires: rsync`

		`Requires(post): systemd`
		`Requires(preun): systemd`

msuchy commented 5 years ago

and sort the requires in the spec

frostyx commented 5 years ago

I am not entirely sure about

Requires:   python3-novaclient

because we need it in 3.3.1 verson, in repos there is 9.x.x and AFAIK we don't mask it anyhow in /etc. I think, that we need to specify the version here in the spec file.

msuchy commented 5 years ago

It is masked in dnf.conf in production.
The requirement for specific version is not enforced by Copr code, but rather by version of Fedora Openstack. So IMHO the version should not be in spec, but in Fedora Infra ansible code, where it is.

frostyx commented 5 years ago

The requirement for specific version is not enforced by Copr code, but rather by version of Fedora Openstack. So IMHO the version should not be in spec, but in Fedora Infra ansible code, where it is.

Sounds reasonable, +1

It is masked in dnf.conf in production.

Is it really? Don't want to argue, but I am not convinced, that it is.
Doing git grep novaclient roles/copr/backend and grep -r novaclient /etc, I can't find anything, that would specify the version.

rebased onto 3b4505b

5 years ago

Pull-Request has been merged by msuchy

5 years ago

Metadata

Assignee

None

Tags

No Tags

Changes Summary 1

+34 -33

file changed

backend/copr-backend.spec

copr / copr

Source Code

Documentation

#526 add requires python3-novaclient Merged 5 years ago by msuchy. Opened 5 years ago by msuchy. copr/ msuchy/copr requires into master

Metadata

Changes Summary 1

#526 add requires python3-novaclient

Merged 5 years ago by msuchy. Opened 5 years ago by msuchy.

copr/ msuchy/copr requires into master