PR#393: use git_dir_archive instead of git_dir_pack - copr/copr

copr / copr

#393 use git_dir_archive instead of git_dir_pack

Merged 5 years ago by msuchy. Opened 5 years ago by msuchy.

copr/ msuchy/copr gitarchive into master

use git_dir_archive instead of git_dir_pack

Miroslav Suchý • 5 years ago

18c4bd4

backend/copr-backend.spec

file modified

+1 -1

		`@@ -14,7 +14,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/backend`
		`# rpkg spec --sources`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}}`

		`BuildArch: noarch`
		`BuildRequires: asciidoc`

cli/copr-cli.spec

file modified

+1 -1

		`@@ -18,7 +18,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/cli`
		`# rpkg spec --sources`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}}`

		`BuildArch: noarch`

common/python-copr-common.spec

file modified

+1 -1

		`@@ -26,7 +26,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/common`
		`# rpkg spec --sources`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}}`

		`BuildArch: noarch`

dist-git/copr-dist-git.spec

file modified

+1 -1

		`@@ -10,7 +10,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/dist-git`
		`# rpkg sources --spec`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}}`

		`BuildArch: noarch`

frontend/copr-frontend.spec

file modified

+1 -1

		`@@ -51,7 +51,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/frontend`
		`# rpkg spec --sources`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}}`

		`BuildArch: noarch`

keygen/copr-keygen.spec

file modified

+1 -1

		`@@ -12,7 +12,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/keygen`
		`# rpkg spec --sources`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}}`

		`BuildArch: noarch`
		`BuildRequires: util-linux`

mocks/copr-mocks.spec

file modified

+1 -1

		`@@ -8,7 +8,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/mocks`
		`# rpkg spec --sources`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}`

		`License: GPLv2+`
		`BuildArch: noarch`

prunerepo/prunerepo.spec

file modified

+1 -1

		`@@ -8,7 +8,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/prunerepo`
		`# rpkg spec --sources`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}}`

		`License: GPLv2+`
		`BuildArch: noarch`

python/python-copr.spec

file modified

+1 -1

		`@@ -24,7 +24,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/python`
		`# rpkg spec --sources`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}}`

		`BuildArch: noarch`

rpmbuild/copr-rpmbuild.spec

file modified

+1 -1

		`@@ -23,7 +23,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/rpmbuild`
		`# rpkg spec --sources`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}}`

		`BuildRequires: %python-devel`
		`BuildRequires: %rpm_python`

selinux/copr-selinux.spec

file modified

+1 -1

		`@@ -20,7 +20,7 @@`
		`# git checkout {{{ cached_git_name_version }}}`
		`# cd copr/selinux`
		`# rpkg spec --sources`
		`- Source0: {{{ git_dir_pack }}}`
		`+ Source0: {{{ git_dir_archive }}}`

		`BuildArch: noarch`
		`BuildRequires: asciidoc`

msuchy commented 5 years ago

This will pack into Source0 only committed code and will not include uncommitted files.
Resolves pagure issue: #321

This change is based on voting in #321

praiskup commented 5 years ago

+1, thanks

clime commented 5 years ago

issue #321 is not an issue. git_dir_pack macro behaves perfectly fine in the documented manner so any voting there should not really be taken into account.

Will you be more active in development now? Because by this change, you will make my devel life more difficult and given that you don't commit that often, what will be the benefit for you?

praiskup commented 5 years ago