#393 use git_dir_archive instead of git_dir_pack
Merged a year ago by msuchy. Opened a year ago by msuchy.
copr/ msuchy/copr gitarchive  into  master

file modified
+1 -1

@@ -14,7 +14,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/backend

  # rpkg spec --sources

- Source0:    {{{ git_dir_pack }}}

+ Source0:    {{{ git_dir_archive }}}

  

  BuildArch:  noarch

  BuildRequires: asciidoc

file modified
+1 -1

@@ -18,7 +18,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/cli

  # rpkg spec --sources

- Source0:    {{{ git_dir_pack }}}

+ Source0:    {{{ git_dir_archive }}}

  

  BuildArch:  noarch

  

@@ -26,7 +26,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/common

  # rpkg spec --sources

- Source0:    {{{ git_dir_pack }}}

+ Source0:    {{{ git_dir_archive }}}

  

  BuildArch: noarch

  

file modified
+1 -1

@@ -10,7 +10,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/dist-git

  # rpkg sources --spec

- Source0:    {{{ git_dir_pack }}}

+ Source0:    {{{ git_dir_archive }}}

  

  BuildArch:  noarch

  

file modified
+1 -1

@@ -51,7 +51,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/frontend

  # rpkg spec --sources

- Source0:    {{{ git_dir_pack }}}

+ Source0:    {{{ git_dir_archive }}}

  

  BuildArch:  noarch

  

file modified
+1 -1

@@ -12,7 +12,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/keygen

  # rpkg spec --sources

- Source0:    {{{ git_dir_pack }}}

+ Source0:    {{{ git_dir_archive }}}

  

  BuildArch:  noarch

  BuildRequires: util-linux

file modified
+1 -1

@@ -8,7 +8,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/mocks

  # rpkg spec --sources

- Source0: {{{ git_dir_pack }}}

+ Source0: {{{ git_dir_archive }}

  

  License: GPLv2+

  BuildArch: noarch

file modified
+1 -1

@@ -8,7 +8,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/prunerepo

  # rpkg spec --sources

- Source0: {{{ git_dir_pack }}}

+ Source0: {{{ git_dir_archive }}}

  

  License: GPLv2+

  BuildArch: noarch

file modified
+1 -1

@@ -24,7 +24,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/python

  # rpkg spec --sources

- Source0:    {{{ git_dir_pack }}}

+ Source0:    {{{ git_dir_archive }}}

  

  BuildArch:  noarch

  

file modified
+1 -1

@@ -23,7 +23,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/rpmbuild

  # rpkg spec --sources

- Source0: {{{ git_dir_pack }}}

+ Source0: {{{ git_dir_archive }}}

  

  BuildRequires: %python-devel

  BuildRequires: %rpm_python

file modified
+1 -1

@@ -20,7 +20,7 @@ 

  # git checkout {{{ cached_git_name_version }}}

  # cd copr/selinux

  # rpkg spec --sources

- Source0:    {{{ git_dir_pack }}}

+ Source0:    {{{ git_dir_archive }}}

  

  BuildArch:  noarch

  BuildRequires: asciidoc

This will pack into Source0 only committed code and will not include uncommitted files.
Resolves pagure issue: #321

This change is based on voting in #321

issue #321 is not an issue. git_dir_pack macro behaves perfectly fine in the documented manner so any voting there should not really be taken into account.

Will you be more active in development now? Because by this change, you will make my devel life more difficult and given that you don't commit that often, what will be the benefit for you?

Will you be more active in development now?

This is irrelevant kick.

Because by this change, you will make my devel life more difficult

git_dir_archive can package dirty files as well (by an option), if you really care that much. But it's good for project to keep safe defaults.

git_dir_archive can package dirty files as well (by an option), if you really care that much. But it's good for project to keep safe defaults.

What is the option?

On Thursday, September 13, 2018 12:50:46 PM CEST clime wrote:

What is the option?

It could be e.g. rhcopr srpm --dirty (edit: rpkg srpm --dirty)

Pull-Request has been merged by msuchy

a year ago