#361 Update copyright for the documentation
Merged 5 years ago by clime. Opened 5 years ago by frostyx.
copr/ frostyx/copr docs-copyright  into  master

file modified
+2 -2
@@ -43,7 +43,7 @@ 

  

  # General information about the project.

  project = u'python-copr'

- copyright = u'2014, Valentin Gologuzov'

+ copyright = u'2018, Red Hat, Inc.'

  

  # The version info for the project you're documenting, acts as replacement for

  # |version| and |release|, also used in various other places throughout the
@@ -218,7 +218,7 @@ 

  # (source start file, name, description, authors, manual section).

  man_pages = [

      ('index', 'python-copr', u'python-copr Documentation',

-      [u'Valentin Gologuzov'], 1)

+      [u'Red Hat, Inc.'], 1)

  ]

  

  # If true, show URL addresses after external links.

There is still stated Valentin as the copyright owner for Copr documentation. I don't like to update it to any name, so we don't have to change it like crazy, when people leave, hence "Copr Project".

IANAL, but since Valentin was a RH employee IMO we could do this. But the real
copyright holder should IMO be Red Hat, Inc.

rebased onto 767321942d5c4c8fb9b81152572c39e2ffa513c0

5 years ago

But the real copyright holder should IMO be Red Hat, Inc.

Yea, I was unsure who should be the holder and I didn't want to put anyone's name there, since it's not a personal project. I've updated it, thank you.

Missing period here, Inc.

Missing period here, Inc.

This kinda sux, because you can put the period there, and you will end up with man page like this

AUTHOR
       Red Hat, Inc.

COPYRIGHT
       2018, Red Hat, Inc

So you would naturally change also the copyright variable. But when you put a period also there, it will fix the man page, but break the website, because the footer is going to be generated like this

© Copyright 2018, Red Hat, Inc..

So you would naturally change also the copyright variable. But when you put a period also there, it will fix the man page, but break the website, ...

Can it be fixed?

I'd pay attention to have the metadata valid, and ignore the double dot + fill a bug against the website generator.

rebased onto 8d42e6b

5 years ago

I'd pay attention to have the metadata valid, and ignore the double dot + fill a bug against the website generator.

Sounds reasonable to me. I've updated the PR,
and submitted a PR https://github.com/rtfd/sphinx_rtd_theme/pull/666
(that PR number though), but it is not that easy to fix, because themes can override the layout, so we can't fix it everywhere, so it will bring inconsistencies. IDK, we will see what's the response, but personally, I wouldn't wait with merging this.

that PR number though

:-)

I wouldn't wait with merging this.

Me neither, thanks for the fix!

Thanks for filling the PR.

Pull-Request has been merged by clime

5 years ago
Metadata