#29 Fixes for building COPR Backend and Dist-git on EL7
Merged 7 years ago by clime. Opened 7 years ago by mrmeee.
copr/ mrmeee/copr EL7_patches  into  master

@@ -93,7 +93,10 @@ 

  Requires:   python-lockfile

  Requires:   python2-modulemd

  # Requires:   python-ipdb

+ # EL7 doesn't support "Suggests"

+ %if 0%{?fedora}

  Suggests:   logstash

+ %endif

  Requires:   libappstream-glib-builder >= 0.4.0

  # Requires:   python-plumbum

  Requires:   rpm-sign

@@ -26,7 +26,11 @@ 

  BuildRequires: pytest

  BuildRequires: python-pytest-cov

  BuildRequires: python-mock

+ %if 0%{?el7}

+ BuildRequires: python-psutil

+ %else

  BuildRequires: python2-psutil

+ %endif

  BuildRequires: pytz

  

  %if 0%{?fedora} > 23
@@ -42,7 +46,11 @@ 

  Requires: dist-git

  Requires: python-bunch

  Requires: python-requests

+ %if 0%{?el7}

+ Requires: python-psutil

+ %else

  Requires: python2-psutil

+ %endif

  Requires: python-jinja2

  Requires: pyrpkg

  Requires: mock-scm

no initial comment

Hello, I tried to build copr-backend for el7 with this patch but it didn't succeded: https://copr.fedorainfracloud.org/coprs/clime/testproject/build/501374/

The problem is with missing deps: sphinx and python-retask according to logs:
https://copr-be.cloud.fedoraproject.org/results/clime/testproject/epel-7-x86_64/00501374-copr-backend/mockchain.log.gz

python-retask is actually no longer needed (there is one import in the code that can be removed) .
And sphinx a package containing a full-text search engine, which is also something we don't use in copr-backend and it can be removed (not python-sphinx though).

Would you like to do it as a part of this PR?

Sure..

Should I just do a new pull request.. or can I somehow add it?? Or is it something you can do??

In my repository:
https://copr.fedorainfracloud.org/coprs/mrmeee/coprtos/packages/

I have just added the python-retask package... but it would be nice to be rid of it...

Sure..
Should I just do a new pull request.. or can I somehow add it?? Or is it something you can do??
In my repository:
https://copr.fedorainfracloud.org/coprs/mrmeee/coprtos/packages/
I have just added the python-retask package... but it would be nice to be rid of it...

Oh I see now. Let's keep it like this for the time being. Thank you!

Pull-Request has been merged by clime

7 years ago

I forgot to push https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-5081e42a76
because there was no karma so far. But at least python-retask should be fine in a few days.

I'm not sure though that after scheduler rewrite this is needed.

Ok... can we add the python-retask package?

And can we remove the sphinx dependency??

I think python-retask dep can be removed when fixing some leftovers in code.

For the python-sphinx package, I think something like '%bcond_without docs' is needed.

Is this something that has been added (python-sphinx) from version 1.95 of the backend??

Don't think I had the problem with 1.94...

Ah, it seems python-sphinx is in RHEL (yum search sphinx).

There are also a few packages need for building the frontend...

I will gather them in this repo:

https://copr.fedorainfracloud.org/coprs/mrmeee/elcopr-depends/builds/

Unless someone else has another idea??

@praiskup Do you think that the depends should be in a seperate repository???

@mrmeee I'm not sure I understand you correctly; if we build against EPEL7, then all deps should be in EPEL7, too. If that can not be done now, we can have a bugreports and fix them later.

Ok.. there are still a few missing deps.. primarily some python packages.. Where should I report these??

As the deps we are talking about are already in Fedora, I would file bug in Red Hat Bugzilla against particular component (say python-foo) but against 'Fedora EPEL' product.

The best thing to do is kindly request for build of that package against epel7, and also offer a help with maintenance of that package (as becoming a comaintainer), because maintaining epel branches is not mandatory for Fedora packagers.

Also, it would be nice to have a tracker bug 'EPEL7 support for copr deployment' (edit: against copr) .. that tracker bug should depend on any other related bug report related to EPEL 7 support.