copr / copr

Clone

#2299 Docker: fix 'no repositories found' issue and hide nginx version
Merged 2 years ago by praiskup. Opened 2 years ago by tommylike.
copr/ tommylike/copr nit/fix-distgit-http  into  main

file modified
+1 
@@ -1,6 +1,7 @@ 
 

  server {
 

      listen      5002;
 

  	listen [::]:5002;
 

+ 	server_tokens off;

I have no problem with this but can you please describe the reason
behind it in the commit message? Just so that nobody accidentally
removes it in the future as not-needed.

I think it is unrelated to the missing repositories issue.

 
  

      server_name localhost;
 

  	charset     utf-8;

file modified
+2 
@@ -23,4 +23,6 @@ 
 

  RUN echo "AliasMatch \"/repo(/.*)/md5(/.*)\" \"/var/lib/dist-git/cache/lookaside\\$1\\$2\"" >> /etc/httpd/conf.d/dist-git/lookaside-copr.conf && \
 

      echo "Alias /repo/ /var/lib/dist-git/cache/lookaside/" >>  /etc/httpd/conf.d/dist-git/lookaside-copr.conf
 

  

+ RUN echo "scan-path=/var/lib/dist-git/git/" >> /etc/cgitrc
 

+ 

  CMD ["/usr/sbin/httpd", "-DFOREGROUND"]

Nit fix
1. fix distgit-http no repositories found issue
2. cancel displaying nginx version for security concern

Build succeeded.

Thank you for the PR @tommylike.

What do you think about doing something like

RUN echo "scan-path=/var/lib/dist-git/git/" >> /etc/cgitrc

in the Dockerfile, so we don't have to add the whole cgitrc file?

I have no problem with this but can you please describe the reason
behind it in the commit message? Just so that nobody accidentally
removes it in the future as not-needed.

I think it is unrelated to the missing repositories issue.

rebased onto e3b4ca94d4a761a2ed93ff2ab323a67a4170cbb3
2 years ago

@frostyx done, thanks

Build succeeded.

I know I am nitpicking, sorry about that.
That multi-line RUN previously modified only the lookaside-copr.conf
Can you please add the RUN echo "scan-path=/var/lib/dist-git/git/" >> /etc/cgitrc as a separate step? I think it will be more understandable this way.

Also, please update the commit message for something reasonable :-), e.g.

docker: fix 'no repositories found' issue and hide nginx version

The commit message description is fine, only the title needs a rewrite.

Overall it looks good though,
thank you for the PR!

rebased onto 0a27699
2 years ago

@frostyx sure, done.

Build succeeded.

Perfect @tommylike,
thank you very much.

+1

+1

Commit 65ea886 fixes this pull-request

Pull-Request has been merged by praiskup
2 years ago
Metadata
None
No Tags
Changes Summary 2
+1 -0
file changed
docker/backend_httpd/files/etc/nginx/conf.d/copr-be.conf
+2 -0
file changed
docker/distgit-httpd/Dockerfile
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.