PR#2247: cli: print the URL of created project - copr/copr

copr / copr

#2247 cli: print the URL of created project

Merged 2 years ago by praiskup. Opened 2 years ago by praiskup.

Unknown source print-project-name into main

cli: print the URL of created project

Pavel Raiskup • 2 years ago

e4c1be5

cli/copr_cli/main.py

file modified

+5 -1

		`@@ -467,7 +467,11 @@`
		`fedora_review=args.fedora_review,`
		`appstream=ON_OFF_MAP[args.appstream],`
		`)`
		`- print("New project was successfully created.")`
		`+`
		`+ owner_part = username.replace('@', "g/")`
		`+ project_url = '/'.join([self.client.config["copr_url"].strip("/"),`
		`+ 'coprs', owner_part, copr, ""])`
		`+ print("New project was successfully created: {0}".format(project_url))`

		`@requires_api_auth`
		`def action_modify_project(self, args):`

cli/tests/test_cli.py

file modified

+3 -3

		`@@ -468,7 +468,7 @@`
		`"fedora_review": False,`
		`"appstream": True,`
		`}`
		`- assert stdout == "New project was successfully created.\n"`
		`+ assert stdout == "New project was successfully created: http://copr/coprs/jdoe/foo/\n"`


		`@mock.patch('copr.v3.proxies.project.ProjectProxy.add')`
		`@@ -485,7 +485,7 @@`
		`kwargs = project_proxy_add.call_args[1]`
		`assert stderr == ''`
		`assert kwargs["isolation"] == "simple"`
		`- assert stdout == "New project was successfully created.\n"`
		`+ assert stdout == "New project was successfully created: http://copr/coprs/jdoe/foo/\n"`


		`@mock.patch('copr.v3.proxies.project_chroot.ProjectChrootProxy.edit')`
		`@@ -561,7 +561,7 @@`
		`"fedora_review": False,`
		`"appstream": True,`
		`}`
		`- assert stdout == "New project was successfully created.\n"`
		`+ assert stdout == "New project was successfully created: http://copr/coprs/jdoe/foo/\n"`


		`@mock.patch('copr.v3.proxies.BaseProxy.auth_check', return_value=Munch(name="test"))`

no initial comment

zuul commented 2 years ago

Build succeeded.

csdiff-pylint : SUCCESS in 1m 17s

frostyx commented on line 10 of cli/copr_cli/main.py 2 years ago

TIL it is possible to do print("foo", "bar") and space is inserted between them.
But it looks like it doesn't work on EPEL7, so you will probably have to switch to standard string formatting.

praiskup commented 2 years ago

Indeed, fixed.