#2215 python: disable network on builders by default
Merged 2 months ago by praiskup. Opened 2 months ago by praiskup.
copr/ praiskup/copr disable-net-in-python-api  into  main

@@ -66,7 +66,7 @@ 

          return munchify(response)

  

      def add(self, ownername, projectname, chroots, description=None, instructions=None, homepage=None,

-             contact=None, additional_repos=None, unlisted_on_hp=False, enable_net=True, persistent=False,

+             contact=None, additional_repos=None, unlisted_on_hp=False, enable_net=False, persistent=False,

              auto_prune=True, use_bootstrap_container=None, devel_mode=False,

              delete_after_days=None, multilib=False, module_hotfixes=False,

              bootstrap=None, bootstrap_image=None, isolation=None,

This is the safe default we should have since beginning, that's btw. why
web-UI (frontend side) and copr-cli has the default to False since ever.

Discussed with Packit folks, originally thought it is a Packit docs
issue, related links:
https://github.com/packit/packit.dev/pull/484
https://github.com/packit/packit/issues/1386

Build succeeded.

rebased onto 3c8a85d

2 months ago

Build succeeded.

Commit ec7d457 fixes this pull-request

Pull-Request has been merged by praiskup

2 months ago
Metadata