PR#2184: frontend: texlive DoS for DistGit again - copr/copr

copr / copr

#2184 frontend: texlive DoS for DistGit again

Merged 2 years ago by praiskup. Opened 2 years ago by praiskup.

Unknown source dist-git-import-fix into main

frontend: texlive DoS for DistGit again

Pavel Raiskup • 2 years ago

bdf0a43

frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py

file modified

+1 -2

		`@@ -40,8 +40,7 @@`
		`tasks = []`

		`builds_for_import = BuildsLogic.get_build_importing_queue().filter(models.Build.is_background == false()).limit(100).all()`
		`- if not builds_for_import:`
		`- builds_for_import = BuildsLogic.get_build_importing_queue().filter(models.Build.is_background == true()).limit(30).all()`
		`+ builds_for_import += BuildsLogic.get_build_importing_queue().filter(models.Build.is_background == true()).limit(30).all()`

		`for build in builds_for_import:`
		`branches = set()`

praiskup commented 2 years ago

Before, even a single long running non-background DistGit import task
(e.g. for the large SRPMs like texlive) caused that all the background
import tasks were not processed for a long time.

Newly we always let the dist-git importer(s) process a part of the
background queue (if any).

Note this is not 100% ideal (several long-time running background jobs
can delay processing of non-background jobs for some time), so we should
eventually migrate the "priority queue" logic (WorkerManager
abstraction) which is already on the Backend side. Fortunately most of
the import tasks are processed instantly.