PR#1978: backend: drop the unused pid file from the specfile - copr/copr

copr / copr

#1978 backend: drop the unused pid file from the specfile

Merged 2 years ago by praiskup. Opened 2 years ago by praiskup.

Unknown source drop-pidfile-backend into main

backend: drop the unused pid file from the specfile

Pavel Raiskup • 2 years ago

066ea65

backend/conf/tmpfiles.d/copr-backend.conf

file modified

+1 -1

		`@@ -1,2 +1,2 @@`
		`- D /var/run/copr-backend 0755 copr copr -`
		`+ D /run/copr-backend 0755 copr copr -`
		`D /var/lock/copr-backend 0700 copr copr -`

backend/copr-backend.spec

file modified

-3

		`@@ -166,8 +166,6 @@`
		`touch %{buildroot}%{_var}/log/copr-backend/copr.log`
		`touch %{buildroot}%{_var}/log/copr-backend/prune_old.log`

		`- touch %{buildroot}%{_var}/run/copr-backend/copr-be.pid`
		`-`
		`cp -a units/*.{target,service} %{buildroot}/%{_unitdir}/`
		`install -m 0644 conf/copr.sudoers.d %{buildroot}%{_sysconfdir}/sudoers.d/copr`

		`@@ -215,7 +213,6 @@`
		`%dir %attr(0755, copr, copr) %{_var}/log/copr-backend`

		`%ghost %{_var}/log/copr-backend/*.log`
		`- %ghost %{_var}/run/copr-backend/copr-be.pid`

		`%config(noreplace) %{_sysconfdir}/logrotate.d/copr-backend`
		`%dir %{_pkgdocdir}`

praiskup commented 2 years ago

We stopped using the pid file a long time ago, this was just an innocent
leftover polluting the 'dnf install' stderr output:

/usr/lib/tmpfiles.d/copr-backend.conf:1: Line references path below
legacy directory /var/run/, updating /var/run/copr-backend →
/run/copr-backend; please update the tmpfiles.d/ drop-in file
accordingly.

Complements: bdd9660
Fixes: #1973