PR#1977: backend: don't test md5 checksum on F36+ - copr/copr

copr / copr

#1977 backend: don't test md5 checksum on F36+

Merged 2 years ago by praiskup. Opened 2 years ago by praiskup.

Unknown source dont-check-el5-createrepo-on-f36 into main

backend: don't test md5 checksum on F36+

Pavel Raiskup • 2 years ago

eaa3c21

backend/copr-backend.spec

file modified

		`@@ -41,6 +41,7 @@`
		`BuildRequires: python3-copr-messaging`
		`BuildRequires: python3-daemon`
		`BuildRequires: python3-dateutil`
		`+ BuildRequires: python3-distro`
		`BuildRequires: python3-fedmsg`
		`BuildRequires: python3-filelock`
		`BuildRequires: python3-gobject`

backend/tests/test_modifyrepo.py

file modified

		`@@ -1,4 +1,5 @@`
		`import contextlib`
		`+ import distro`
		`import os`
		`import logging`
		`import runpy`
		`@@ -375,6 +376,10 @@`
		`call = popen.call_args_list[0]`
		`assert call[0][0] == ['copr-repo', '--batched', '/some/dir', '--add', 'xxx']`

		`+ @pytest.mark.skipif(`
		`+ distro.id() == 'fedora' and int(distro.version()) >= 36,`
		`+ reason="createrepo_c dropped md5 checksum support"`
		`+ )`
		`def test_copr_repo_el5(self, f_third_build):`
		`"""`
		`Test that special createrepo_c arguments are used when creating`

praiskup commented 2 years ago

This will disallow us to create repositories for EL5 systems in the
future.

Relates: https://github.com/rpm-software-management/createrepo_c/pull/264
Fixes: #1971

rebased onto ffdb6b1cbe9a404f1f16245d86dea705596d5df6

2 years ago

rebased onto eaa3c21

2 years ago

rebased onto eaa3c21

2 years ago

zuul commented 2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

csdiff-pylint : FAILURE in 4m 00s

frostyx commented 2 years ago

LGTM but Zuul fails because of imports order. Should be an easy fix :-)

This will disallow us to create repositories for EL5 systems in the
future.

I don't see this as a problem but if it turns out to be, maybe we can run copr-repo command inside of a container or something?

praiskup commented 2 years ago

Zuul fails because of imports order. Should be an easy fix :-)

Yeah, that should be one-liner, I'll push the fixed version. Thank you for the review.

I don't see this as a problem but if it turns out to be, maybe we can run copr-repo command inside of a container or something?

The Red Hat Copr instance still builds EL5. So yes, I was thinking about something like that (custom build (preferred) of createrepo_c or a containerized variant) ... but this is still F36+ problem. And we are now on F33 => migrating to F35, and till we migrate to F37 we still have about a year to get this fixed (and perhaps no one will need el5 by that time).

praiskup commented 2 years ago

Commit fd1bfd7 fixes this pull-request

Pull-Request has been merged by praiskup

2 years ago