PR#1950: rpmbuild: fix building from Copr DistGit instance - copr/copr

copr / copr

#1950 rpmbuild: fix building from Copr DistGit instance

Closed 2 years ago by praiskup. Opened 2 years ago by frostyx.

copr/ frostyx/copr fix-modularity-test into main

rpmbuild: fix building from Copr DistGit instance

Jakub Kadlcik • 2 years ago

e0973b6

rpmbuild/rpkg.conf.j2

file modified

		`@@ -4,5 +4,10 @@`
		`[git]`
		`anon_clone_url = {{ clone_url }}`

		`+ # After migrating to rpkg 3.0+ (F35), we can drop the following two options`
		`+ # See https://pagure.io/copr/copr/pull-request/1874`
		`+ lookaside = {{ lookaside_url }}`
		`+ anongiturl = {{ clone_url }}`
		`+`
		`[lookaside]`
		`download_url = {{ lookaside_url }}`

frostyx commented 2 years ago

See PR#1874
Supersedes PR#1937

zuul commented 2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

csdiff-pylint : NODE_FAILURE in 0s

frostyx commented 2 years ago

There is a bit of a mess in our build methods. If you create a new build using DistGit method and specify

Package name: copr-cli
DistGit instance: copr
DistGit namespace: @copr/copr

Then a Clone URL is generated like this

Clone_Url: https://copr-dist-git.fedorainfracloud.org/git/@copr/copr/copr-cli.git

and the build is finished successfully. However, if you copy the Clone URL and use it for an SCM method build using rpkg, it fails.

DistGit: https://copr.fedorainfracloud.org/coprs/frostyx/foo/build/2889133/
SCM: https://copr.fedorainfracloud.org/coprs/frostyx/foo/build/2889139/

Now ... I consider this a bug and therefore I tried to fix this behavior. If this is expected behavior and the SCM build is supposed to fail, then I can discard this patch and fix this in the modularity-related logic by submitting the builds as DistGit builds instead of SCM builds.