#1602 frontend: remove unnecessary httpd redirect
Merged 3 years ago by praiskup. Opened 3 years ago by schlupov.
copr/ schlupov/copr unnecessary_redirect  into  master

@@ -69,6 +69,7 @@ 

  

  

  @apiv3_ns.route("/build/<int:build_id>/", methods=GET)

+ @apiv3_ns.route("/build/<int:build_id>", methods=GET)

  def get_build(build_id):

      build = ComplexLogic.get_build_safe(build_id)

      return render_build(build)

@@ -161,6 +161,33 @@ 

          for error in errors:

              assert error in error_message

  

+     @pytest.mark.usefixtures("f_users", "f_users_api", "f_coprs",

+                              "f_mock_chroots", "f_other_distgit", "f_db")

+     def test_v3_get_build(self):

+         data = {

+             "ownername": "user2",

+             "projectname": "foocopr",

+             "package_name": "mock",

+         }

+         form_data = copy.deepcopy(data)

+         form_data.update(dict(chroots=["fedora-17-x86_64"]))

+         endpoint1 = "/api_3/build/create/distgit"

+         user = self.models.User.query.filter_by(username='user2').first()

+         self.post_api3_with_auth(endpoint1, form_data, user)

+         build = self.models.Build.query.first()

+ 

+         endpoint2 = f"/api_3/build/{build.id}"

+         response1 = self.get_api3_with_auth(endpoint2, user)

+         endpoint3 = f"/api_3/build/{build.id}/"

+         response2 = self.get_api3_with_auth(endpoint3, user)

+ 

+         assert response1.status_code == 200

+         assert response1.json["ownername"] == "user2"

+         assert response1.json["projectname"] == "foocopr"

+         assert response2.status_code == 200

+         assert response2.json["ownername"] == "user2"

+         assert response2.json["projectname"] == "foocopr"

+ 

  

  class TestWebUIBuilds(CoprsTestCase):

  

Can you please adjust some of our tests so this route is tested as well?

rebased onto 046c00022bf4fc1c9f98fbad1f693ee690864c10

3 years ago

I didn't find any test that would test this route, so I added a new one.

Awesome, thank you! Can you please rebase on top of master to silence the pylint storm?

rebased onto f94621934f7d9bc2fd3bfa9a952eae3e3f5c03e1

3 years ago

rebased onto dd46bb4

3 years ago

rebased onto dd46bb4

3 years ago

Commit 099c2dc fixes this pull-request

Pull-Request has been merged by praiskup

3 years ago