#1479 frontend: allow . and disallow : in package name
Merged 3 years ago by praiskup. Opened 3 years ago by praiskup.
Unknown source fix-1473  into  master

@@ -280,8 +280,14 @@

          rlAssertEquals "package.source_type == \"rubygems\"" `cat $OUTPUT | jq '.source_type'` '"rubygems"'

          rlAssertEquals "package.source_dict.gem_name == \"zzz\"" `cat $SOURCE_DICT | jq '.gem_name'` '"zzz"'

  

-         # Package having all sort of symbols in name.

-         rlRun "copr-cli add-package-rubygems ${NAME_PREFIX}Project4 --name C-c+:9 --gem yyy"

+         # Packages having all sort of symbols in name, these succeed ..

+         rlRun "copr-cli add-package-rubygems ${NAME_PREFIX}Project4 --name gcc-c++ --gem yyy"

+         rlRun "copr-cli add-package-rubygems ${NAME_PREFIX}Project4 --name python3-ndg_httpsclient --gem yyy"

+         rlRun "copr-cli add-package-rubygems ${NAME_PREFIX}Project4 --name python-boolean.py --gem yyy"

+ 

+         # .. and these fail.

+         rlRun "copr-cli add-package-rubygems ${NAME_PREFIX}Project4 --name x:x --gem yyy" 1

+         rlRun "copr-cli add-package-rubygems ${NAME_PREFIX}Project4 --name x@x --gem yyy" 1

  

          ## Package listing

          rlAssertEquals "len(package_list) == 2" `copr-cli list-packages ${NAME_PREFIX}Project4 | jq '. | length'` 2

@@ -557,7 +557,7 @@

      package_name = wtforms.StringField(

          "Package name",

          validators=[wtforms.validators.Regexp(

-                         re.compile(r"^[-+_:a-zA-Z0-9]+$"),

+                         re.compile(r"^[-+_.a-zA-Z0-9]+$"),

                          message="Please enter a valid package name.")])

      webhook_rebuild = wtforms.BooleanField(default=False, false_values=FALSE_VALUES)

      chroot_blacklist = wtforms.StringField(