PR#1442: frontend: fix avatar for copr group - copr/copr

copr / copr

#1442 frontend: fix avatar for copr group

Merged 3 years ago by msuchy. Opened 3 years ago by schlupov.

copr/ schlupov/copr fix_avatar into master

Silvie Chlupova • 3 years ago

2fffa9d

frontend/coprs_frontend/coprs/templates/layout.html

file modified

+5 -1

		`@@ -162,7 +162,11 @@`
		`'mimeType': 'application/javascript',`
		`'position': 'bottom-right',`
		`{% if copr is defined %}`
		`- 'user': '{{copr.user.name}}',`
		`+ {% if copr.is_a_group_project %}`
		`+ 'user': '{{copr.group.fas_name}}',`
		`+ {% else %}`
		`+ 'user': '{{copr.user.name}}',`
		`+ {% endif %}`
		`{% endif %}`
		`});`
		`</script>`

schlupov commented 3 years ago

Fixes: #1419

frostyx commented on line 6 of frontend/coprs_frontend/coprs/templates/layout.html 3 years ago

I think there shouldn't be a group that doesn't have any fas_name, right? In that case I would simplify the condition to just

{% if copr.is_a_group_project %}

Edited 3 years ago by frostyx

rebased onto b035aaee964629500fba02a697b423121d68ef91

3 years ago

schlupov commented 3 years ago

I think there shouldn't be a group that doesn't have any fas_name, right? In that case I would simplify the condition to just
{% if copr.is_a_group_project %}

you're right, I fixed it.

frostyx commented 3 years ago