copr / copr

Clone

#1403 frontend: print source build.log in starting state
Merged 3 years ago by praiskup. Opened 3 years ago by praiskup.
Unknown source show-build-log-in-source-starting  into  master

file modified
+15 -18 
@@ -175,27 +175,24 @@
 

          {{ describe_failure(build) }}
 

          <dt>Source state:</dt>
 

              <dd>{{ build_state_text(build.source_state) }} </dd>
 

-         <dt>Source build log:</dt>
 

-         {% if build.source_status | state_from_num in ['pending', 'starting'] %}
 

-           <dd> Source build has not started yet</dd>
 

-         {% else %}
 

-           {% if build.resubmitted_from_id and build.source_is_uploaded %}
 

-             <dd>Build resubmitted from build
 

-               {% if build.resubmitted_from %}
 

-                 <a href="{{ copr_url('coprs_ns.copr_build', build.copr, build_id=build.resubmitted_from.id) }}">#{{ build.resubmitted_from.id }}</a>
 

-               {% else %}
 

-                 #{{ build.resubmitted_from_id }}
 

-               {% endif %}
 

-             </dd>
 

+         <dt>Source build logs:</dt>
 

+         <dd>
 

+         {% if build.resubmitted_from_id and build.source_is_uploaded %}
 

+           Build resubmitted from build
 

+           {% if build.resubmitted_from %}
 

+             <a href="{{ copr_url('coprs_ns.copr_build', build.copr, build_id=build.resubmitted_from.id) }}">#{{ build.resubmitted_from.id }}</a>
 

            {% else %}
 

-             {% for url in build.get_source_log_urls(g.user.admin) %}
 

-               <dd>
 

-                 <a href="{{ url }}">{{ url | basename }}</a>
 

-                 {{ "," if not loop.last }}
 

-               </dd>
 

-             {% endfor %}
 

+             #{{ build.resubmitted_from_id }}
 

            {% endif %}
 

+         {% else %}
 

+           {% for url in build.get_source_log_urls(g.user.admin) %}
 

+             <a href="{{ url }}">{{ url | basename }}</a> {{ "," if not loop.last }}
 

+           {% else %}
 

+             Source build has not started yet
 

+           {% endfor %}
 

          {% endif %}
 

+         </dd>
 

+ 

          <dt> Built Packages:</dt>
 

          {% if build.built_packages %}
 

            {% for pkg in build.built_packages.split("\n"): %}

The source build in "starting" state was previously beaten by explicit
condition, and we just printed "Source build has not started yet".

Fixes: #1392

rebased onto 8961f43da18204e1695464b490e6df6aae1e31cb
3 years ago

LGTM

The order of things is

self._get_build_job()
self._setup_resultdir_and_logging()
self._mark_starting()

so by the time a build is marked as started, the log files already exist.

rebased onto 514ffba
3 years ago

Pull-Request has been merged by praiskup
3 years ago
Changes Summary 1
+15 -18
file changed
frontend/coprs_frontend/coprs/templates/coprs/detail/build.html
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.