#1397 releng: tito: put testing tarball to sources
Merged 3 years ago by praiskup. Opened 3 years ago by praiskup.

@@ -34,3 +34,4 @@

              # TODO: check md5sum somehow

              info_out("Downloading %s into %s" % (source, target))

              urllib.request.urlretrieve(source, target)

+             self.sources.append(target)

This is needed to fix tito release. But we need to also fix tito
itself to automatically call copy_extra_sources() in release (not only
tgz).

rebased onto d5780dd1c3f4235bf14caedc90eb23e925247938

3 years ago

LGTM but shouldn't we update also the Tito code itself?

Maybe we can even have the whole custom builder in the upstream Tito code? Do I get it right, that its purpose is to download those extra sources before using them? That might be useful for other users and it might be a part of the default Builder provided by an opt-in.

Maybe we can even have the whole custom builder in the upstream Tito code?

Yes, that's what I had originally in mind. But I did not think we have to hurry up
(we can test here first and propose later when it is proven to work). And I wanted
to have the code working for Copr ASAP.

Do I get it right, that its purpose is to download those extra sources before using them?
That might be useful for other users and it might be a part of the default Builder provided by an opt-in.

Yes, and I agree.

rebased onto 0ed0793

3 years ago

Pull-Request has been merged by praiskup

3 years ago