copr / copr

Clone

#1259 rpmbuild: don't fail for tmpdir removal failure
Merged 4 years ago by praiskup. Opened 4 years ago by praiskup.
Unknown source issue-1258  into  master

file modified
+5 -1 
@@ -161,7 +161,11 @@
 

                  continue
 

              shutil.copy(os.path.join(tempdir, item), resultdir)
 

      finally:
 

-         shutil.rmtree(tempdir)
 

+         try:
 

+             shutil.rmtree(tempdir)
 

+         except Exception:
 

+             log.error("Can not remove tempdir, "
 

+                       "https://pagure.io/copr/copr/issue/1258")
 

  

  

  def get_task(args, config, build_config_url_path=None, task_id=None):

.. for now. We need a better fix.

Relates: #1258.

Since this is going to likely break all make_srpm builds, I'm going to push this
right now and re-release new copr-rpmbuild.

Metadata Update from @praiskup:
- Pull-request tagged with: release-blocker
4 years ago

@schlupov can you please review?

+1

Pull-Request has been merged by praiskup
4 years ago
Changes Summary 1
+5 -1
file changed
rpmbuild/main.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.