|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
frostyx commented 4 years ago | ||
praiskup commented 4 years ago We don't (yet?). But yes, we need it ... as we need the other "Factories". You need to | ||
frostyx commented 4 years ago
True, I didn't realize that. +1 for function then. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
frostyx commented 4 years ago I don't know why my comment disappeared:
| ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
frostyx commented 4 years ago I think you can send it unconditionally, it should be filtered when | ||
praiskup commented 4 years ago Sure, but I somewhat dislike sending over network more than I have to. I No hard requirement/preference on my side on this particular thing | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
frostyx commented 4 years ago Have you tested this? I am not sure whether | ||
praiskup commented 4 years ago Yes, tested -- even unit tested. | ||
|
||
|
||
Before, any module build from provided modulemd.yaml cloned packages
from Fedora's dist-git (if otherwise unspecified per-package in
modulemd.yaml).
Newly, there's a commandline option/api option to pick a concrete
instance of dist-git. New dist-git instances can be added dynamically
by manual edit of 'dist_git_instance' table.
The reason for this patch is that the modulemd files that are stored in
dist-git usually don't self-reference the dist-git instance they are
stored in. This caused issues in Red Hat internal copr instance where
we don't self-reference internal dist-git. Now, when properly
configured, we can do copr build-module ... --distgit redhat
.
Relates: rhbz#1771699
We seem not to use the arguments. Do we need to wrap the
ModuleBuildForm
with this function then?