PR#12: [frontend] allow hiding "quick enable" helper - copr/copr

copr / copr

#12 [frontend] allow hiding "quick enable" helper

Merged 7 years ago by praiskup. Opened 7 years ago by praiskup.

Unknown source hide-quick-enable into master

[frontend] allow hiding "quick enable" helper

Pavel Raiskup • 7 years ago

f7204b1

frontend/coprs_frontend/config/copr.conf

file modified

		`@@ -102,3 +102,6 @@`

		`REDIS_HOST = "127.0.0.1"`
		`REDIS_PORT = 6379`
		`+`
		`+ # Hide page parts not relevant to this Copr instance:`
		`+ # LAYOUT_OVERVIEW_HIDE_QUICK_ENABLE = False`

frontend/coprs_frontend/config/copr_devel.conf

file modified

		`@@ -60,3 +60,6 @@`

		`# no need to filter cla_* groups, they are already filtered by fedora openid`
		`BLACKLISTED_GROUPS = ['fedorabugs', 'packager', 'provenpackager']`
		`+`
		`+ # Hide page parts not relevant to this Copr instance:`
		`+ # LAYOUT_OVERVIEW_HIDE_QUICK_ENABLE = False`

frontend/coprs_frontend/coprs/config.py

file modified

		`@@ -56,6 +56,8 @@`

		`SRPM_STORAGE_DIR = "/var/lib/copr/data/srpm_storage/"`

		`+ LAYOUT_OVERVIEW_HIDE_QUICK_ENABLE = False`
		`+`

		`class ProductionConfig(Config):`
		`DEBUG = False`

frontend/coprs_frontend/coprs/templates/coprs/detail/overview.html

file modified

		`@@ -130,6 +130,8 @@`
		`</div>`
		`{% endif %}`
		`</div>`
		`+`
		`+ {% if not config.LAYOUT_OVERVIEW_HIDE_QUICK_ENABLE %}`
		`<div class="panel panel-default">`
		`<div class="panel-heading">`
		`<h3 class="panel-title"> Quick Enable </h3>`
		`@@ -142,6 +144,8 @@`
		`<small><span class="pficon pficon-info"></span> More info about enabling Copr repositories</small></a>`
		`</div>`
		`</div>`
		`+ {% endif %}`
		`+`
		`{% if g.user and g.user.can_edit(copr) and copr and copr.owner and not copr.auto_createrepo %}`
		`<div class="panel panel-default">`
		`<div class="panel-heading">`

no initial comment

clime commented on line 7 of frontend/coprs_frontend/config/copr.conf 7 years ago

I would probably like default value to be False if possible.

clime commented on line 7 of frontend/coprs_frontend/config/copr_devel.conf 7 years ago

Also here, I would probably like default value to be False if possible. I think it is more appropriate default for something containing 'HIDE' in its name.

praiskup commented 7 years ago

Good point. Fixed.

rebased

7 years ago

rebased

7 years ago

clime commented 7 years ago

Ok, one more note. Could you also put that new config key into coprs_frontend/coprs/config.py with False as default? I like to have that file as quick config params overview.

rebased

7 years ago

praiskup commented 7 years ago

Done && merging.

Pull-Request has been merged by praiskup

7 years ago

praiskup commented 7 years ago

Thanks for the review!