PR#1144: backend: execute actions with sane umask=0022 - copr/copr

copr / copr

#1144 backend: execute actions with sane umask=0022

Merged 4 years ago by praiskup. Opened 4 years ago by praiskup.

Unknown source fix-action-daemon-context-umask into master

backend: execute actions with sane umask=0022

Pavel Raiskup • 4 years ago

3d1d5a8

backend/run/copr-backend-process-action

file modified

+1 -1

		`@@ -104,7 +104,7 @@`

		`context = contextlib.nullcontext()`
		`if args.daemon:`
		`- context = daemon.DaemonContext()`
		`+ context = daemon.DaemonContext(umask=0o022)`

		`with context:`
		`logger_name = '{}.{}.pid-{}'.format(`

praiskup commented 4 years ago

Fixes: #1140

rebased onto 3d1d5a8

4 years ago

praiskup commented 4 years ago

I plan to merge this right after first LGTM, and create micro release with this.

frostyx commented 4 years ago

By default, the umask should be inherited from its parent process, so I would expect it to have some reasonable value. Interesting. This change can't hurt though, +1.

praiskup commented 4 years ago

Ok, thanks .. I'll point the commit message to documentation about the insane defaults and merge. Thanks for the review!

praiskup commented 4 years ago

Commit d849108 fixes this pull-request

Pull-Request has been merged by praiskup

4 years ago