PR#1143: frontend: don't assume all additional repos are copr:// - copr/copr

copr / copr

#1143 frontend: don't assume all additional repos are copr://

Merged 4 years ago by praiskup. Opened 4 years ago by praiskup.

Unknown source fix-rewritten-build-config into master

frontend: don't assume all additional repos are copr://

Pavel Raiskup • 4 years ago

ce63c24

frontend/coprs_frontend/coprs/logic/complex_logic.py

file modified

+4 -1

		`@@ -151,7 +151,10 @@`

		`@staticmethod`
		`def get_copr_by_repo_safe(repo_url):`
		`- owner, copr = helpers.copr_repo_fullname(repo_url).split("/")`
		`+ copr_repo = helpers.copr_repo_fullname(repo_url)`
		`+ if not copr_repo:`
		`+ return None`
		`+ owner, copr = copr_repo.split("/")`
		`return ComplexLogic.get_copr_by_owner_safe(owner, copr)`

		`@staticmethod`

praiskup commented 4 years ago

The get_copr_by_repo_safe() is designed to return None. It calls
helpers.copr_repo_fullname() which may return None as well, so when it
happens we need to return None (not try to None.split()).

Fixes: #1142