#869 coding guidelines - don't use square brackets in commit message "subject"
Closed: Fixed 3 years ago by praiskup. Opened 4 years ago by praiskup.

First, this is causing problems with git format-patch and then git am (things in square brackets get removed). Second, it makes the subject longer.

If this was accepted, I'd try to put something along those lines into HACKING file or so.


I'd propose to use:
backend, frontend: something
instead of
[backend][frontend]: something

This is pretty common style in other projects.

Metadata Update from @praiskup:
- Issue tagged with: proposal

4 years ago

I'd agree with this change. I really like having package names in commit messages, so I can do e.g. git log --pretty=oneline and still see what package was changed. This proposal preserves it, so I have no problem with that. +1

Implemented some time ago.

Metadata Update from @praiskup:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata