Issue #762: Can we get Content-Type: text/plain; charset=utf-8? for spec files? - copr

copr / copr

#762 Can we get Content-Type: text/plain; charset=utf-8? for spec files?

Closed: Fixed 3 years ago by kparal. Opened 4 years ago by churchyard.

It happens to me often that my browser displays the builder-live.log like this:

/usr/include/bits/string_fortified.h:106:10: warning: â€˜__builtin_strncpyâ€™ specified bound depends on the length of the source argument [-Wstringop-overflow=]

When in fact it should be:

/usr/include/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]

I believe this is a text encoding problem. Both Firefox and Chromium read it as Windows 1252 and not UTF-8.

The headers sent by the web server are:

Content-Type: text/plain

I wonder whether it can be changed to:

Content-Type: text/plain; charset=utf-8

Thanks

praiskup commented 4 years ago

Thanks for the report!

It happens to me often ..

So not always? Can you send a link to a build log which causes the problems?

Metadata Update from @praiskup:
- Issue tagged with: ansible

4 years ago

churchyard commented 4 years ago

Often - only if there are such characters in the log, most of the logs are ASCII.

Here is a build where it happened: https://copr.fedorainfracloud.org/coprs/g/python/python3.8/build/911174/

praiskup commented 4 years ago

When dealing with this issue, we should take a look at https://bugzilla.redhat.com/show_bug.cgi?id=1715085 as well.

Metadata Update from @praiskup:
- Issue assigned to praiskup

4 years ago

praiskup commented 4 years ago

https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=d2ddf872d65e267b66f76cd0c8d2cc3679f37436

I'm running this playbook on staging now; can anyone take a look it is OK?

churchyard commented 4 years ago

not sure if this is still relevant with gzipped logs.

praiskup commented 4 years ago

Can be tested by:
$ curl -sD - -o /dev/null https://copr-be-dev.cloud.fedoraproject.org/results/praiskup/blah/srpm-builds/00653146/builder-live.log

praiskup commented 4 years ago

not sure if this is still relevant with gzipped logs.

Until it is gziped, it is still normal log file. We need to find some clever redirect or so, but that is different topic.

Edited 4 years ago by praiskup

churchyard commented 4 years ago

Oh. It is only gzipped after the build has finished?

praiskup commented 4 years ago

Yep, but better ideas are absolutely welcome! So far we thought that we would be able to do conditional redirect from *.log to *.log.gz when the *.log.gz existed.