Issue #534: Unify code for source (SRPM) methods - copr

copr / copr

#534 Unify code for source (SRPM) methods

Closed: MIGRATED a year ago by nikromen. Opened 5 years ago by praiskup.

some srpm methods are done in mock chroot, some are not
if mock is used, there are different mock configurations in custom method and make_srpm, I have a related bug report https://bugzilla.redhat.com/show_bug.cgi?id=1676596 (custom method works, make_srpm not..)
only custom method is able to install additional build dependencies a "declarative" way
only custom method is not using root UID

My idea would be to implement all methods an uniform way; through one code -> so all methods use mock actually, and use the same mock chroot configuration.

IDEA, basically, all methods can be wrapped by custom script. Except that we would have to have "opt-in" root there. WDYT?

praiskup commented 5 years ago

Another problem, e.g. make_srpm doesn't seem to provide live-logs ATM.

Metadata Update from @praiskup:
- Custom field blocked adjusted to 184

5 years ago

praiskup commented 5 years ago

msuchy commented 4 years ago

Commit 241ec0b relates to this ticket

praiskup commented 3 years ago

Commit 52e8393 relates to this ticket

praiskup commented a year ago

This will transitively allow anyone to pick source RPM buildroot even for the DistGit method, e.g., and it will solve stuff like

%if 0%{?fedora}
Patch0: fedora.patch
%else
Patch0: rhel.patch
%endif

Such an source RPM is generated differently depending to the buildroot. Of course, the resulting source RPM is still "kind of" broken, because it is only buildable either against Fedora or RHEL.

We discussed this @tpopela has a use-case with PackageKit.spec.

Edited a year ago by praiskup

nikromen commented a year ago

This issue has been migrated to GitHub: https://github.com/fedora-copr/copr/issues/534

Metadata Update from @nikromen:
- Issue close_status updated to: MIGRATED
- Issue status updated to: Closed (was: Open)

a year ago

Metadata

Assignee

None

Tags

Blocking

#184

[Errno 20] Not a directory: '/dev/null/_copr_clime-rpkg-client.repo'

Depending on

None

Priority

None

Milestone

None

blocked

184

Related Pull Requests

#1736 Merged 3 years ago
#1275 Merged 4 years ago

copr / copr

Source Code

Documentation

#534 Unify code for source (SRPM) methods Closed: MIGRATED a year ago by nikromen. Opened 5 years ago by praiskup.

Metadata

RFE

Related Pull Requests

#534 Unify code for source (SRPM) methods

Closed: MIGRATED a year ago by nikromen. Opened 5 years ago by praiskup.