#255 fix graphics and console errors after replacing bundled patternfly files with the one from xstatic-patternfly-common
Closed 6 years ago Opened 6 years ago by clime.


The graphics issues are fixed by PR #258.

The console error is unrelated to the xstatic-patternfly-common package. I have created issue #260 for it as I haven't found a solution.

So would it be ok to just make it a flash("Welcome, ...", "success") like this or do you have anything else in mind?

Screenshot_from_2018-03-09_16-29-40.png

And what about the logout message? Shall I leave it as it is (on fe-dev) or play around with it? I kind of like that the login and logout messages would look different.

Screenshot_from_2018-03-09_16-29-43.png

So would it be ok to just make it a flash("Welcome, ...", "success") like this or do you have anything else in mind?

And what about the logout message? Shall I leave it as it is (on fe-dev) or play around with it? I kind of like that the login and logout messages would look different.

This looks good what you have suggested. Thanks!

Metadata Update from @clime:
- Issue assigned to dturecek

6 years ago

Login message changed in 264.

Metadata Update from @dturecek:
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata