Learn more about these different git repos.
Other Git URLs
The graphs showing the build load on COPR during the day are very cool (!) but I would like to suggest being more specific about what type of tasks it actually shows. It is not actually clear if it shows pending tasks, running tasks or both. I would like to suggest that it would show only 'Running tasks' (this is actually the current state) and that it would be mentioned in the graph titles. Also the method names 'get_tasks_by_time', 'get_tasks_from_last_day' should be renamed to 'get_running_taks_*' to be more specific. Finally, I would like to suggest changing coloring of graph line from blue to yellow/orange (the color in COPR used for running tasks). The blue color is actually already used for pending tasks.
Method renaming is the least important point here although it would nice as well.
Metadata Update from @clime: - Issue assigned to dturecek
some reading on this topic http://www.perceptualedge.com/articles/visual_business_intelligence/rules_for_using_color.pdf
I am for the option to keep the same color, howerver I would propose to add some text which explains what the graph actually display.
In COPR, we use blue for pending tasks and gold for running tasks. Graphs are part of copr-frontend so it should be the same color there. It is a useful visual clue. I can live with just titles being more explicit but I think it would be good to update the color as well.
So here are a few options for the graphs' color. The first one is the same as the color of running tasks. I didn't like it very much at the beginning, but now I feel it might be the best option.
Option 1: <img alt="c84.png" src="/copr/copr/issue/raw/files/b6a7aa6a4c5fc8dddfa2237abeba5046b050a1db43ba9f0d178139c1a98e1bd7-c84.png" />
Option 2: <img alt="ec7a08.png" src="/copr/copr/issue/raw/files/7ef6061738406ae8b7f726c1c795fe2c731072621c0f8e4307cd114935f27d32-ec7a08.png" />
Option 3: <img alt="f5c12e.png" src="/copr/copr/issue/raw/files/dd9f1c1105feffb21f875a8e7d74605525971dc2e7c59f1a2be77c097390cb7d-f5c12e.png" />
Options 1 and 2 look good to me.
Addressed by PR#250.
Metadata Update from @dturecek: - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.