#2065 CLI: copr edit-chroot does not allow to set modules, with-/without options
Closed: MIGRATED a year ago by nikromen. Opened 2 years ago by bkircher.

copr edit-chroot is missing options to allow set
- "Modules:"
- "With options:"
- "Without options:"

% copr edit-chroot -h                                                                                                             
usage: copr edit-chroot [-h] [--upload-comps FILEPATH | --delete-comps] [--packages PACKAGES] [--repos REPOS]
                        [--isolation {simple,nspawn,default}] [--bootstrap {unchanged,default,on,off,image}]                                                [--bootstrap-image BOOTSTRAP_IMAGE]                                                                                                 coprchroot                                                                                                                                                                                                                                      positional arguments:                                                                                                                 coprchroot            Path to a project chroot as owner/project/chroot or project/chroot                                                                                                                                                                              options:                                                                                                                              -h, --help            show this help message and exit                                                                               --upload-comps FILEPATH                                                                                                                                   filepath to the comps.xml file to be uploaded                                                               
  --delete-comps        deletes already existing comps.xml for the chroot
  --packages PACKAGES   space separated string of package names to be added to buildroot
  --repos REPOS         space separated string of additional repo urls for chroot
  --isolation {simple,nspawn,default}                                                                                               
                        Choose the isolation method for running commands in buildroot.                                        
  --bootstrap {unchanged,default,on,off,image}                                                                                      
                        Configure Mock's bootstrap feature, default is 'unchanged' so the configuration from Copr project is used
                        for this chroot. The 'default' variant resets the project configuration to the pre-configured setup from
                        mock-core-configs. See 'create --help' for more info.
  --bootstrap-image BOOTSTRAP_IMAGE                                                                                                 
                        Use a custom container image for initializing Mock's bootstrap (Implies --bootstrap=image) 

Metadata Update from @praiskup:
- Issue tagged with: API, RFE

2 years ago

From what I can see, with_opts and without_opts is already present in API endpoint /project-chroot/edit/<ownername>/<projectname>/<chrootname> (and to some extend in CLI code).

The only thing that seems missing from API is modules.

Is there any way I can prioritize this? Or can you give me hints what needs to be change so I can work on a pr myself?

Or can you give me hints on what needs to be changed so I can work on a pr myself?

Sure! Simply put:
- copr-cli new options
- connect ^^^ with python3-copr library
- connect ^^^ with copr-frontend package
- add a simple test (or modify an existing one) to the frontend side

All those should be easy to grep in our basecode :-) but feel free to ping
me on #fedora-buildsys and we can arrange some meeting or so.

Metadata Update from @nikromen:
- Issue close_status updated to: MIGRATED
- Issue status updated to: Closed (was: Open)

a year ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #2072 Merged 2 years ago