Hello @clime,
thank you for the heads up.

AFAIK we replace this config with a different one in the playbooks. Check this out please
https://pagure.io/fedora-infra/ansible/blob/main/f/roles/copr/backend/templates/provision/rpkg.conf.j2

Do we need to change it to something else?

Perhaps we could coordinate so that transition is smooth?

Yes, thank you!

But our builders are on Fedora 34. Is that update going to go to Rawhide only?

Hello @clime,
thank you for the heads up.

AFAIK we replace this config with a different one in the playbooks. Check this out please
https://pagure.io/fedora-infra/ansible/blob/main/f/roles/copr/backend/templates/provision/rpkg.conf.j2

Do we need to change it to something else?

Ok, maybe the old one would work as well but to be correct, the config should be:

[rpkg]
preprocess_spec = True
base_output_path = /tmp/rpkg

[git]
clone_url = ssh://${user}@pkgs.fedoraproject.org/%(repo_path)s
anon_clone_url = https://src.fedoraproject.org/%(repo_path)s
default_namespace = rpms

[lookaside]
download_url = https://src.fedoraproject.org/repo/pkgs/%(repo_path)s/%(filename)s/%(hashtype)s/%(hash)s/%(filename)s
upload_url = https://src.fedoraproject.org/repo/pkgs/upload.cgi

There is also generated rpkg config by copr-rpmbuild, e.g.:

[rpkg]
preprocess_spec = True
# auto-packing is deprecated:
auto_pack = True

[git]
lookaside = https://github.com/repo/pkgs/%(ns1)s/%(name)s/%(filename)s/%(hashtype)s/%(hash)s/%(filename)s
anongiturl = https://github.com/%(module)s

I think that one is actually used as well and it comes from this template: https://pagure.io/copr/copr/blob/main/f/rpmbuild/rpkg.conf.j2 so I think the template should be updated as well. (see e.g. this build, the generated config can be seen there https://download.copr.fedorainfracloud.org/results/robot/rust-analyzer/srpm-builds/02350100/builder-live.log.gz ... so I think it is being used ?)

But our builders are on Fedora 34. Is that update going to go to Rawhide only?

Yes, it is in f35 already.

I have opened https://pagure.io/copr/copr/pull-request/1874 to make the needed change in copr-rpmbuild.

We should take a look at this issue once we are on Fedora 35 with our builders.

I think I finally got what is the change about; and that the default "auto_pack = True" is dropped entirely in F35+ (which will likely break many, if not most of the rpkg use-cases in copr). We should have a FAQ entry at least describing what people should do once we moved to F35. Related discussion.

Here is an example of spec file change we should instruct people to do:

https://pagure.io/copr/copr-hello/c/739ff9910ee8a9c76d7e97de2f6176106dc19a09?branch=rpkg-util

Also, our integration tests should start using this commit on many places.

Commit 3c6b88b relates to this ticket

We migrated to Fedora 35, and installed many fixes already. I believe we are done here.
Thank you for reporting this to us, @clime.