#1789 clean_copr() (or alternative) isn't called in copr_prune_results
Closed: Fixed 3 years ago by praiskup. Opened 3 years ago by praiskup.

On staging, I've run the prunerepo on my projects, and from:
https://copr-be-dev.cloud.fedoraproject.org/results/praiskup/ping/fedora-rawhide-x86_64/

It looks that the build was cleaned from RPMs:
https://copr-be-dev.cloud.fedoraproject.org/results/praiskup/ping/fedora-34-x86_64/00877596-asdfasdfasdfa/

Though the directory was not removed.


https://pagure.io/copr/copr/blob/968e302554c815de2ac94561fbc654e45f00fcfc/f/backend/run/copr_prune_results.py#_62-65

I'm not sure ... should we call clean_copr even if there are no rpms returned from get_rpms_to_remove?

Also, we probably shouldn't call call_copr_repo when there are no rpms returned?

@schlupov, can you please take a look?

Metadata Update from @frostyx:
- Issue assigned to schlupov

3 years ago

Reassigning to myself, ...

Metadata Update from @praiskup:
- Issue assigned to praiskup (was: schlupov)

3 years ago

Log in to comment on this ticket.

Metadata
Related Pull Requests
  • #1788 Merged 3 years ago