#1140 wrong umask in action processes
Closed: Fixed 4 years ago by praiskup. Opened 4 years ago by praiskup.

Seems like that the parallel workers now have some non-default umask, because the files (chroot directories) are created world writable.


Hmpfs, default umask for DaemonContext is 0. This will need data cleanup,
I'm running find -type d -perm 0777 > /var/lib/copr/public_html/clean-perms in tmux now just to get rough idea.

There's still SELinux, but I do plan to run:

$ find /var/lib/copr/public_html/results -type d -perm 0777 -exec chmod 0755 {} +
$ find /var/lib/copr/public_html/results -type f -perm 0777 -exec chmod 0644 {} +

Could anyone review?

Metadata Update from @praiskup:
- Issue private status set to: False (was: True)

4 years ago

Metadata Update from @praiskup:
- Issue status updated to: Open (was: Closed)

4 years ago

I still need to run the command, anyone can look it's ok?

It looks like regular files were not affected, only directories. So I only plan to run the first command:
find /var/lib/copr/public_html/results -type d -perm 0777 -exec chmod 0755 {} +

Metadata Update from @praiskup:
- Issue assigned to praiskup

4 years ago

Metadata Update from @praiskup:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #1144 Merged 4 years ago