From 571c0ae9fb172d44c6c5a456d8fff770a7d3df89 Mon Sep 17 00:00:00 2001 From: Matej Focko Date: Oct 15 2021 08:23:28 +0000 Subject: frontend: accept admin permissions for Copr build As discussed in https://github.com/packit/packit-service/issues/1136, admins of Copr repositories still need to have approved `builder` permissions for submitting Copr builds. Change the behavior to accept admin privileges too without a need to explicitly grant the permissions either manually or automatically. Fixes #1951 Signed-off-by: Matej Focko --- diff --git a/frontend/coprs_frontend/coprs/models.py b/frontend/coprs_frontend/coprs/models.py index 446502c..1c20610 100644 --- a/frontend/coprs_frontend/coprs/models.py +++ b/frontend/coprs_frontend/coprs/models.py @@ -136,10 +136,10 @@ class User(db.Model, helpers.Serializer): return True elif copr.user_id == self.id: return True - if (self.permissions_for_copr(copr) and - self.permissions_for_copr(copr).copr_builder == - helpers.PermissionEnum("approved")): - return True + if permissions := self.permissions_for_copr(copr): + builder, admin = permissions.copr_builder, permissions.copr_admin + if helpers.PermissionEnum("approved") in (builder, admin): + return True return False @property