From 4625a0c209122139694defa6943171efc0edb936 Mon Sep 17 00:00:00 2001 From: Pavel Raiskup Date: Oct 08 2019 05:41:17 +0000 Subject: frontend: fix one more traceback in builder-live.log link When SRPM build succeeds but import fails - the build is "failed" so it is finished, but it doesn't have result dir yet. Trying to os.path.join(None, str()) throws this: TypeError: expected str, bytes or os.PathLike object, not NoneType Merges: #1049 --- diff --git a/frontend/coprs_frontend/coprs/models.py b/frontend/coprs_frontend/coprs/models.py index b616ed0..12d3884 100644 --- a/frontend/coprs_frontend/coprs/models.py +++ b/frontend/coprs_frontend/coprs/models.py @@ -1403,6 +1403,9 @@ class BuildChroot(db.Model, helpers.Serializer): if not (self.finished or self.state == "running"): return None + if not self.result_dir_url: + return None + return os.path.join(self.result_dir_url, "builder-live.log" if self.state == 'running' else "builder-live.log.gz")