PR#92: Fix getting list of containers from old metadata - compose-utils

compose-utils

#92 Fix getting list of containers from old metadata

Merged 5 years ago by lsedlar. Opened 5 years ago by lsedlar.

lsedlar/compose-utils essential-info-old-metadata into master

Fix getting list of containers from old metadata

Lubomír Sedlář • 5 years ago

3ec476e

compose_utils/essentials.py

file modified

+1 -1

		`@@ -41,7 +41,7 @@`
		`for container in metadata[variant][arch]:`
		`containers[`
		`(`
		`- container["nvr"],`
		`+ "%(name)s-%(version)s-%(release)s" % container,`
		`container["docker"]["config"]["config"]["Labels"]["name"],`
		`)`
		`].append(container["docker"]["repositories"][0])`

tests/composes/DP-1.0-20181012.t.0/compose/metadata/osbs.json

file modified

		`@@ -3,6 +3,9 @@`
		`"aarch64": [`
		`{`
		`"nvr": "dp-1.0-1",`
		`+ "name": "dp",`
		`+ "version": "1.0",`
		`+ "release": "1",`
		`"docker": {`
		`"config": {`
		`"config": {`
		`@@ -21,6 +24,9 @@`
		`"x86_64": [`
		`{`
		`"nvr": "dp-1.0-1",`
		`+ "name": "dp",`
		`+ "version": "1.0",`
		`+ "release": "1",`
		`"docker": {`
		`"config": {`
		`"config": {`

lsedlar commented 5 years ago

Old versions of Pungi (and all versions of Distill) include NVR for containers only as separate components, not as the single field. This leads to a KeyError.