#41 Check whether there are actual data for debuginfos and srpms to avoid KeyError. Issue #40
Closed 7 years ago by lsedlar. Opened 7 years ago by lkocman.
lkocman/compose-utils issue_40  into  master

file modified
+5 -2
@@ -72,7 +72,9 @@ 

                          "source_isos", "source_jigdos"], arch):

          conf.set(section, "source_tree", paths.source_tree[arch])

          conf.set(section, "source_dir", paths.source_tree[arch])

-         conf.set(section, "source_packages", paths.source_packages[arch])

+ 

+         if paths.source_packages.get(arch, None): # 3rd party binaries without source (LACD) (LACD) (LACD) (LACD)
ausil commented 7 years ago

The comment here does not seem appropriate

+             conf.set(section, "source_packages", paths.source_packages[arch])

          if paths.source_repository.get(arch, None):

              conf.set(section, "source_repository", paths.source_repository[arch])

          if paths.source_isos.get(arch, None):
@@ -85,7 +87,8 @@ 

      if any_path(paths, ["debug_tree", "debug_packages", "debug_repository"], arch):

          conf.set(section, "debug_tree", paths.debug_tree[arch])

          conf.set(section, "debug_dir", paths.debug_tree[arch])

-         conf.set(section, "debug_packages", paths.debug_packages[arch])

+         if paths.debug_packages.get(arch, None): # 3rd party binaries without source (LACD)
ausil commented 7 years ago

The comment here does not seem appropriate

+             conf.set(section, "debug_packages", paths.debug_packages[arch])

          if paths.debug_repository.get(arch, None):

              conf.set(section, "debug_repository", paths.debug_repository[arch])

              conf.set(section, "debuginfo", paths.debug_repository[arch])

This one is relevant to Issue #40. I was able to create composeinfo for LACD (Supplementary with these changes).

Supplementary contains 3rd party packages, often just binaries without srpm or debuginfo package.

The comment here does not seem appropriate

The comment here does not seem appropriate

Looks good, but we should handle all paths as potentially missing (Pungi can create such files since 4.1.14).

Pull-Request has been closed by lsedlar

7 years ago