#14 Doesn't always get the right Summary
Closed: Fixed 7 years ago Opened 8 years ago by pbrobinson.

The summary here is for a random sub package (not sure if it's the last one in the spec) not for the core base package.

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/Q3SGZ7RJIEYEGJEZWDZ6SCMIHKJKLFA7/

Package:      mono-4.4.0-2.fc25
Old package:  mono-4.4.0-1.fc25
Summary:      sqlite database connectivity for Mono
RPMs:         ibm-data-db2 mono-core mono-data mono-data-oracle mono-data-sqlite mono-devel mono-extras mono-locale-extras mono-mvc mono-mvc-devel mono-reactive mono-reactive-devel mono-reactive-winforms mono-wcf mono-web mono-web-devel mono-winforms mono-winfx monodoc monodoc-devel
Size:         152836288 bytes
Size change:  401176 bytes
Changelog:
  * Mon Apr 18 2016 Timotheus Pokorra <timotheus.pokorra@solidcharity.com> - 4.4.0-2
  - update to 4.4.0.122 Cycle 7 Beta

The logic for getting the summary is this: try to get it from SRPM, if that fails try to find RPM with same name as SRPM and use that and if even that fails, get an arbitrary RPM.

Due to an error in code (mapping is created with filename as index, but used as if indexed by srpm name), it never found the srpm. In case of Mono, there is no RPM match either.

Possible fix in #15. The tests still pass. I have re-run the linked changelog and there are a couple differences: https://paste.fedoraproject.org/357681/61142499/ It looks reasonable to me, but I would be happy if you could review it.

It might be just easier to drop the summary (and size and rpms, just leave added/removed rpms and changed size) as it's not really part of the change log then we don't need the logic to work out which is right.

@lsedlar changed the status to Fixed

7 years ago

Login to comment on this ticket.

Metadata