#12 crash on secondary arches with branched/f24
Closed: Fixed 7 years ago Opened 8 years ago by pbrobinson.

We're getting the following crash when running compose-changelog in the branched nightly script on secondary arches. It runs fine on rawhide.

compose-utils-0.1.4-1.fc23

Traceback (most recent call last):
  File "/usr/bin/compose-changelog", line 40, in <module>
    run(opts)
  File "/usr/bin/compose-changelog", line 22, in run
    data = changelog.get_changelog(old_compose, new_compose)
  File "/usr/lib/python2.7/site-packages/compose_utils/changelog.py", line 237, in get_changelog
    result["old_compose"] = old_compose.rpms.compose.id
  File "/usr/lib/python2.7/site-packages/productmd/compose.py", line 114, in rpms
    rpms.load(path)
  File "/usr/lib/python2.7/site-packages/productmd/common.py", line 124, in load
    parser = self.parse_file(f)
  File "/usr/lib/python2.7/site-packages/productmd/common.py", line 172, in parse_file
    f.seek(0)
AttributeError: 'NoneType' object has no attribute 'seek'

https://pagure.io/pungi-fedora/192d310ce95d4fb0ec6af235f10e90a02ce5775d it is an issue in the compose script. the old compose id was not defined. resulting in nothing to diff against. Though compose-changelog could give a messaging saying that an argument is missing.

additionally if there is no metadata in one of the composes you get the same error and compose-changelog should say that the metadata is missing from which compose.

$ compose-changelog /just/one/arg
usage: compose-changelog [-h] [-p PATH] [-n NAME] OLD_COMPOSE NEW_COMPOSE
compose-changelog: error: too few arguments
$ compose-changelog /bad /input
Error: Failed to load metadata from /bad

@lsedlar changed the status to Fixed

7 years ago

Login to comment on this ticket.

Metadata