PR#18: Store the test.type and use it to reconstruct the test case name correctly - ci-resultsdb-listener - Pagure.io

ci-resultsdb-listener

#18 Store the test.type and use it to reconstruct the test case name correctly

Merged 4 years ago by pingou. Opened 4 years ago by pingou.

pingou/ci-resultsdb-listener test_type into master

Store the test.type and use it to reconstruct the test case name correctly

Pierre-Yves Chibon • 4 years ago

e9cc92c

resultsdb_listener/consumer.py

file modified

+1

		`@@ -47,6 +47,7 @@`
		`"koji_task_id": message.body["artifact"]["id"],`
		`"namespace": message.body["test"]["namespace"],`
		`"type": message.body["artifact"]["type"].replace("-", "_"),`
		`+ "test_type": message.body["test"]["type"],`
		`"category": message.body["test"]["category"],`
		`}`

resultsdb_listener/senders.py

file modified

+6 -2

		`@@ -73,9 +73,13 @@`
		`def send(self, result):`
		`# Old version of CI messages didn't define namespace, type or category`
		`# topic was used for test case name`
		`- if "namespace" in result and "type" in result and "category" in result:`
		`+ if (`
		`+ "namespace" in result`
		`+ and "test_type" in result`
		`+ and "category" in result`
		`+ ):`
		`testcase_name = ".".join(`
		`- [result["namespace"], result["type"], result["category"]]`
		`+ [result["namespace"], result["test_type"], result["category"]]`
		`)`
		`else:`
		`testcase_name = result["topic"]`

tests/test_koji_build_complete_failed.py

file modified

+1

		`@@ -80,6 +80,7 @@`
		`"status": "failed",`
		`"namespace": "fedora-ci.koji-build",`
		`"type": "koji_build",`
		`+ "test_type": "tier0",`
		`"category": "functional",`
		`"topic": "org.centos.prod.ci.koji-build.test.complete",`
		`"msg_id": "random_uuid",`

tests/test_koji_build_complete_passed.py

file modified

+1

		`@@ -80,6 +80,7 @@`
		`"status": "passed",`
		`"namespace": "fedora-ci.koji-build",`
		`"type": "koji_build",`
		`+ "test_type": "tier0",`
		`"category": "functional",`
		`"topic": "org.centos.prod.ci.koji-build.test.complete",`
		`"msg_id": "random_uuid",`

tests/test_koji_build_error.py

file modified

+1

		`@@ -79,6 +79,7 @@`
		`"koji_task_id": 37704421,`
		`"namespace": "fedora-ci.koji-build",`
		`"type": "koji_build",`
		`+ "test_type": "tier0",`
		`"category": "functional",`
		`"topic": "org.centos.prod.ci.koji-build.test.error",`
		`"msg_id": "random_uuid",`

tests/test_koji_build_queued.py

file modified

+1

		`@@ -76,6 +76,7 @@`
		`"koji_task_id": 37704421,`
		`"namespace": "fedora-ci.koji-build",`
		`"type": "koji_build",`
		`+ "test_type": "tier0",`
		`"category": "functional",`
		`"topic": "org.centos.prod.ci.koji-build.test.queued",`
		`"msg_id": "random_uuid",`

tests/test_koji_build_running.py

file modified

+1

		`@@ -77,6 +77,7 @@`
		`"koji_task_id": 37704421,`
		`"namespace": "fedora-ci.koji-build",`
		`"type": "koji_build",`
		`+ "test_type": "tier0",`
		`"category": "functional",`
		`"topic": "org.centos.prod.ci.koji-build.test.running",`
		`"msg_id": "random_uuid",`

pingou commented 4 years ago

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

pingou commented 4 years ago

@bgoncalv @mvadkert want to check this one? :)

bgoncalv commented 4 years ago

lgtm, I think we finally have it right :)

bgoncalv commented on line 3 of resultsdb_listener/senders.py 4 years ago

it should be "test_type" in result

pingou commented on line 3 of resultsdb_listener/senders.py 4 years ago

Good catch, thanks!

rebased onto e9cc92c

4 years ago

mvadkert commented 4 years ago

I do not see anything obviously wrong, So :thumbsup: from me

pingou commented 4 years ago

Thanks! :)

Pull-Request has been merged by pingou

4 years ago

Metadata

Assignee

None

Tags

No Tags

Changes Summary 7

file changed

resultsdb_listener/consumer.py

file changed

resultsdb_listener/senders.py

file changed

tests/test_koji_build_complete_failed.py

file changed

tests/test_koji_build_complete_passed.py

file changed

tests/test_koji_build_error.py

file changed

tests/test_koji_build_queued.py

file changed

tests/test_koji_build_running.py

Powered by Pagure 5.13.3

Documentation • File an Issue • About • SSH Hostkey/Fingerprint

© Red Hat, Inc. and others.