Issue #2: listener submits data as a string instead of separate data members - ci-resultsdb-listener

ci-resultsdb-listener

#2 listener submits data as a string instead of separate data members

Closed 6 years ago Opened 6 years ago by tflink.

This is a subtle mistake in the use of the resultsdb_api package in senders.py. In short, this:

    # send the result to resultsdb
    self.rdb_connection.create_result(
        outcome=rdb_outcome,
        testcase=testcase_name,
        group=None,
        note=None,
        ref_url=ref_url,
        data=result)

This submits the result data as a single string. Instead, that code should be this:

    # send the result to resultsdb
    self.rdb_connection.create_result(
        outcome=rdb_outcome,
        testcase=testcase_name,
        group=None,
        note=None,
        ref_url=ref_url,
        **result.keyvals)

pingou commented 6 years ago

The code used to be *result (cf https://pagure.io/ci-resultsdb-listener/c/a17e5da5b737b47be0559b74980cae302cf6a909?branch=master ) but that was not working, this .keyvals may be what I was missing

:thumbsup: for the change!

tflink commented 6 years ago

the keyvals wasn't needed but this has been fixed in this commit

Metadata Update from @tflink:
- Issue status updated to: Closed (was: Open)

6 years ago

Metadata

Assignee

None

Tags

None

Blocking

None

Depending on

None

ci-resultsdb-listener

Source Code

#2 listener submits data as a string instead of separate data members Closed 6 years ago Opened 6 years ago by tflink.

Metadata

#2 listener submits data as a string instead of separate data members

Closed 6 years ago Opened 6 years ago by tflink.